Issue 5450115: code review 5450115: godoc: <pre> must not occur inside

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5450115: code review 5450115: godoc: <pre> must not occur inside (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by dupoxy

Modified:
13 years, 3 months ago

Reviewers:

CC:
golang-dev, volker.dobler, rsc

Visibility:
Public.

Description

godoc: <pre> must not occur inside Fixes issue 2532

Patch Set 2 : diff -r 58a2e71c39b9 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 5eb676b44184 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r ff75ab89c70d https://go.googlecode.com/hg/ #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	lib/godoc/example.html	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
	M	lib/godoc/package.html	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

dupoxy

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 3 months ago (2011-12-07 00:56:47 UTC) #1

volker.dobler

http://codereview.appspot.com/5450115/diff/2001/lib/godoc/package.html File lib/godoc/package.html (right): http://codereview.appspot.com/5450115/diff/2001/lib/godoc/package.html#newcode91 lib/godoc/package.html:91: <code>{{node_html .Decl $.FSet}}</code> I think the pre is needed ...

13 years, 3 months ago (2011-12-07 10:00:01 UTC) #2

dupoxy

Hello golang-dev@googlegroups.com, dr.volker.dobler@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 3 months ago (2011-12-07 10:10:41 UTC) #3

dupoxy

13 years, 3 months ago (2011-12-07 10:14:29 UTC) #4

rsc

13 years, 3 months ago (2011-12-07 20:00:40 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=290ad29728fa ***

godoc: <pre> must not occur inside <p>
Fixes issue 2532

R=golang-dev, dr.volker.dobler, rsc
CC=golang-dev
http://codereview.appspot.com/5450115

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages