Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(67)

Issue 5449114: code review 5449114: gc: fix spurious typecheck loop in &composite literal (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 3 months ago by rsc
Modified:
13 years, 3 months ago
Reviewers:
ken3
CC:
ken2, golang-dev
Visibility:
Public.

Description

gc: fix spurious typecheck loop in &composite literal Fixes issue 2538.

Patch Set 1 #

Patch Set 2 : diff -r a14a4310f4e9 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r a14a4310f4e9 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M src/cmd/gc/typecheck.c View 1 1 chunk +1 line, -0 lines 0 comments Download
A test/fixedbugs/bug380.go View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 3 months ago (2011-12-07 20:48:54 UTC) #1
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=b854cc52d41e *** gc: fix spurious typecheck loop in &composite literal Fixes issue ...
13 years, 3 months ago (2011-12-07 20:48:59 UTC) #2
ken3
13 years, 3 months ago (2011-12-08 09:17:27 UTC) #3
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b