code review 5449067: spec: additional composite literal shortenings per Go 1 plan

spec: additional composite literal shortenings per Go 1 plan

[rsc, 2011-12-02 18:22:56]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[gri, 2011-12-02 18:30:12]

LGTM
leaving for r

http://codereview.appspot.com/5449067/diff/1002/doc/go_spec.html
File doc/go_spec.html (right):

http://codereview.appspot.com/5449067/diff/1002/doc/go_spec.html#newcode2130
doc/go_spec.html:2130: [...]Point{{1.5, -3.5}, {0, 0}}  // same as
[...]Point{Point{1.5, -3.5}, Point{0, 0}}
I'd keep these three comments aligned , maybe even all of them (that way they
are a separate "graphical element" and the code - which is of primary concern -
becomes more visible)

[r, 2011-12-02 18:59:15]

LGTM

http://codereview.appspot.com/5449067/diff/1002/doc/go_spec.html
File doc/go_spec.html (right):

http://codereview.appspot.com/5449067/diff/1002/doc/go_spec.html#newcode2124
doc/go_spec.html:2124: but not to unkeyed values.
the term 'keyed' literal does not appear in the spec.

The same elisions may be applied to struct literal elements, but only if they
are keyed by struct field name <section reference>.

[rsc, 2011-12-02 19:07:11]

> http://codereview.appspot.com/5449067/diff/1002/doc/go_spec.html#newcode2124
> doc/go_spec.html:2124: but not to unkeyed values.
> the term 'keyed' literal does not appear in the spec.
>
> The same elisions may be applied to struct literal elements, but only if
> they are keyed by struct field name <section reference>.

It's hard to see in the raw html but the reference
would be the current section, since this is the
section that describes the key: value form in
composite literals.  Rewritten to:

    The same elisions may be applied to field values within a struct literal,
    but only if the value has a field name key.

?

[r2, 2011-12-02 19:09:06]

On Dec 2, 2011, at 11:07 AM, Russ Cox wrote:

>> http://codereview.appspot.com/5449067/diff/1002/doc/go_spec.html#newcode2124
>> doc/go_spec.html:2124: but not to unkeyed values.
>> the term 'keyed' literal does not appear in the spec.
>> 
>> The same elisions may be applied to struct literal elements, but only if
>> they are keyed by struct field name <section reference>.
> 
> It's hard to see in the raw html but the reference
> would be the current section, since this is the
> section that describes the key: value form in
> composite literals.  Rewritten to:
> 
>    The same elisions may be applied to field values within a struct literal,
>    but only if the value has a field name key.

LGTM

[rsc, 2011-12-02 19:12:59]

*** Submitted as http://code.google.com/p/go/source/detail?r=cc2107d49e88 ***

spec: additional composite literal shortenings per Go 1 plan

R=golang-dev, gri, r, r
CC=golang-dev
http://codereview.appspot.com/5449067