Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2272)

Issue 5449067: code review 5449067: spec: additional composite literal shortenings per Go 1 plan (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 11 months ago by rsc
Modified:
7 years, 11 months ago
Reviewers:
CC:
golang-dev, gri, r, r2
Visibility:
Public.

Description

spec: additional composite literal shortenings per Go 1 plan

Patch Set 1 #

Patch Set 2 : diff -r f1194e89f56f https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f1194e89f56f https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r f1194e89f56f https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 6caadf39ae97 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M doc/go_spec.html View 1 2 3 1 chunk +18 lines, -3 lines 0 comments Download

Messages

Total messages: 6
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
7 years, 11 months ago (2011-12-02 18:22:56 UTC) #1
gri
LGTM leaving for r http://codereview.appspot.com/5449067/diff/1002/doc/go_spec.html File doc/go_spec.html (right): http://codereview.appspot.com/5449067/diff/1002/doc/go_spec.html#newcode2130 doc/go_spec.html:2130: [...]Point{{1.5, -3.5}, {0, 0}} // ...
7 years, 11 months ago (2011-12-02 18:30:12 UTC) #2
r
LGTM http://codereview.appspot.com/5449067/diff/1002/doc/go_spec.html File doc/go_spec.html (right): http://codereview.appspot.com/5449067/diff/1002/doc/go_spec.html#newcode2124 doc/go_spec.html:2124: but not to unkeyed values. the term 'keyed' ...
7 years, 11 months ago (2011-12-02 18:59:15 UTC) #3
rsc
> http://codereview.appspot.com/5449067/diff/1002/doc/go_spec.html#newcode2124 > doc/go_spec.html:2124: but not to unkeyed values. > the term 'keyed' literal does ...
7 years, 11 months ago (2011-12-02 19:07:11 UTC) #4
r2
On Dec 2, 2011, at 11:07 AM, Russ Cox wrote: >> http://codereview.appspot.com/5449067/diff/1002/doc/go_spec.html#newcode2124 >> doc/go_spec.html:2124: but ...
7 years, 11 months ago (2011-12-02 19:09:06 UTC) #5
rsc
7 years, 11 months ago (2011-12-02 19:12:59 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=cc2107d49e88 ***

spec: additional composite literal shortenings per Go 1 plan

R=golang-dev, gri, r, r
CC=golang-dev
http://codereview.appspot.com/5449067
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b