src/pkg/crypto/x509/x509.go - Issue 5448065: code review 5448065: Add a []byte argument to hash.Hash to allow an allocati...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/pkg/crypto/x509/x509.go

Issue 5448065: code review 5448065: Add a []byte argument to hash.Hash to allow an allocati... (Closed)

Patch Set: diff -r 5ef46981bf5e https://go.googlecode.com/hg/ Created 13 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/pkg/crypto/x509/x509.go

===================================================================

--- a/src/pkg/crypto/x509/x509.go

+++ b/src/pkg/crypto/x509/x509.go

@@ -398,7 +398,7 @@

}

h.Write(signed)

- digest := h.Sum()

+ digest := h.Sum(nil)

switch pub := c.PublicKey.(type) {

case *rsa.PublicKey:

@@ -957,7 +957,7 @@

h := sha1.New()

h.Write(tbsCertContents)

- digest := h.Sum()

+ digest := h.Sum(nil)

signature, err := rsa.SignPKCS1v15(rand, priv, crypto.SHA1, digest)

if err != nil {

@@ -1024,7 +1024,7 @@

h := sha1.New()

h.Write(tbsCertListContents)

- digest := h.Sum()

+ digest := h.Sum(nil)

signature, err := rsa.SignPKCS1v15(rand, priv, crypto.SHA1, digest)

if err != nil {

« no previous file with comments | « src/pkg/crypto/tls/prf.go ('k') | src/pkg/exp/ssh/client.go » ('j') | no next file with comments »