src/pkg/compress/flate/huffman_bit_writer.go - Issue 5447069: code review 5447069: use new strconv API

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/pkg/compress/flate/huffman_bit_writer.go

Issue 5447069: code review 5447069: use new strconv API (Closed)

Patch Set: diff -r 497c07d73643 https://go.googlecode.com/hg/ Created 13 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/pkg/compress/flate/huffman_bit_writer.go

===================================================================

--- a/src/pkg/compress/flate/huffman_bit_writer.go

+++ b/src/pkg/compress/flate/huffman_bit_writer.go

@@ -106,8 +106,8 @@

}

func (err WrongValueError) Error() string {

- return "huffmanBitWriter: " + err.name + " should belong to [" + strconv.Itoa64(int64(err.from)) + ";" +

- strconv.Itoa64(int64(err.to)) + "] but actual value is " + strconv.Itoa64(int64(err.value))

+ return "huffmanBitWriter: " + err.name + " should belong to [" + strconv.FormatInt(int64(err.from), 10) + ";" +

+ strconv.FormatInt(int64(err.to), 10) + "] but actual value is " + strconv.FormatInt(int64(err.value), 10)

}

func (w *huffmanBitWriter) flushBits() {

« no previous file with comments | « src/pkg/archive/tar/writer.go ('k') | src/pkg/compress/flate/inflate.go » ('j') | no next file with comments »