Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1743)

Issue 5440049: Allows for automatic renumbering of measure numbers at volta repeats. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 11 months ago by MikeSol
Modified:
7 years, 11 months ago
Reviewers:
Keith, pkx166h, Neil Puttock, carl.d.sorensen, mike
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Allows for automatic renumbering of measure numbers at volta repeats.

Patch Set 1 #

Total comments: 26

Patch Set 2 : Responses to various comments. #

Patch Set 3 : Adds regtest. #

Patch Set 4 : Gets rid of log problems, makes code more Lily-like. #

Total comments: 5

Patch Set 5 : Incorporates Keith's comments. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -5 lines) Patch
M lily/bar-number-engraver.cc View 1 2 3 4 6 chunks +102 lines, -3 lines 1 comment Download
M lily/volta-repeat-iterator.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ly/engraver-init.ly View 1 chunk +1 line, -0 lines 0 comments Download
M scm/define-context-properties.scm View 1 1 chunk +4 lines, -0 lines 0 comments Download
M scm/define-event-classes.scm View 1 1 chunk +2 lines, -1 line 0 comments Download
M scm/define-music-callbacks.scm View 1 2 3 4 1 chunk +28 lines, -0 lines 0 comments Download
M scm/define-music-display-methods.scm View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scm/define-music-properties.scm View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M scm/define-music-types.scm View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 14
MikeSol
I'm not sure if this is the best way to go about it, but it ...
7 years, 11 months ago (2011-11-28 21:59:42 UTC) #1
Carl
Thanks for taking this on. I sense that this is a step in the direction ...
7 years, 11 months ago (2011-11-29 00:04:52 UTC) #2
Keith
Works nicely. I'm inspired to name some variables in Irish now! And, I'll be sure ...
7 years, 11 months ago (2011-11-29 03:54:42 UTC) #3
pkx166h
Passes Make and make check just gives me --snip-- /home/jlowe/lilypond-git/input/regression/display-lily-tests.log @@ -13,6 +13,9 @@ Test ...
7 years, 11 months ago (2011-11-29 07:46:24 UTC) #4
MikeSol
I'll just say to all you haters of `renvoi' that: --) There is no English ...
7 years, 11 months ago (2011-11-29 12:08:52 UTC) #5
mike_apollinemike.com
On Nov 29, 2011, at 1:08 PM, mtsolo@gmail.com wrote: > > The only problem that ...
7 years, 11 months ago (2011-11-29 12:20:29 UTC) #6
mike_apollinemike.com
On Nov 29, 2011, at 1:20 PM, mike@apollinemike.com wrote: > On Nov 29, 2011, at ...
7 years, 11 months ago (2011-11-29 14:43:48 UTC) #7
pkx166h
Passes Make and Make check James
7 years, 11 months ago (2011-11-29 22:02:00 UTC) #8
Keith
Now it looks quite good, and still works great. C'est si bon. Is maith é ...
7 years, 11 months ago (2011-11-30 05:29:04 UTC) #9
mike_apollinemike.com
On Nov 30, 2011, at 6:29 AM, k-ohara5a5a@oco.net wrote: > Now it looks quite good, ...
7 years, 11 months ago (2011-11-30 09:14:12 UTC) #10
pkx166h
Passes make and make check James
7 years, 11 months ago (2011-12-01 17:38:24 UTC) #11
Neil Puttock
http://codereview.appspot.com/5440049/diff/9003/lily/bar-number-engraver.cc File lily/bar-number-engraver.cc (right): http://codereview.appspot.com/5440049/diff/9003/lily/bar-number-engraver.cc#newcode156 lily/bar-number-engraver.cc:156: scm_string_concatenate (scm_list_2 (scm_number_to_string (bn, scm_from_int (10)), Would be better ...
7 years, 11 months ago (2011-12-06 12:04:54 UTC) #12
mike_apollinemike.com
Le Dec 6, 2011 à 1:04 PM, n.puttock@gmail.com a écrit : > > http://codereview.appspot.com/5440049/diff/9003/lily/bar-number-engraver.cc > ...
7 years, 11 months ago (2011-12-06 12:07:03 UTC) #13
Neil Puttock
7 years, 11 months ago (2011-12-12 12:07:41 UTC) #14
On 2011/12/06 12:07:03, mike_apollinemike.com wrote:

> Good to see you back on the list!

Cheers mate. :)  I'm afraid I'm only passing through temporarily though. 
Hopefully will get back into the swing of things after Christmas.

Cheers,
Neil
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b