Issue 5437147: code review 5437147: html/template: simplify ExecuteTemplate a little

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5437147: code review 5437147: html/template: simplify ExecuteTemplate a little (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by r

Modified:
13 years, 4 months ago

Reviewers:
r2, rog

CC:
MikeSamuel, golang-dev

Visibility:
Public.

Description

html/template: simplify ExecuteTemplate a little Allow the text template to handle the error case of no template with the given name. Simplification suggested by Mike Samuel.

Patch Set 2 : diff -r 77404a124c34 https://go.googlecode.com/hg/ #

Total comments: 1

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -8 lines)			Patch
	M	src/pkg/html/template/template.go	View		2 chunks	+7 lines, -8 lines	1 comment	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Hello mikesamuel@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 4 months ago (2011-12-06 19:05:48 UTC) #1

*** Submitted as http://code.google.com/p/go/source/detail?r=8eb71b50b26f *** html/template: simplify ExecuteTemplate a little Allow the text template to ...

13 years, 4 months ago (2011-12-06 20:47:22 UTC) #4

rog

http://codereview.appspot.com/5437147/diff/5001/src/pkg/html/template/template.go File src/pkg/html/template/template.go (right): http://codereview.appspot.com/5437147/diff/5001/src/pkg/html/template/template.go#newcode56 src/pkg/html/template/template.go:56: panic("html/template internal error: template escaping out of sync") i ...

13 years, 4 months ago (2011-12-07 09:02:58 UTC) #5

13 years, 4 months ago (2011-12-07 19:14:56 UTC) #6

On Dec 7, 2011, at 1:02 AM, rogpeppe@gmail.com wrote:

> 
>
http://codereview.appspot.com/5437147/diff/5001/src/pkg/html/template/templat...
> File src/pkg/html/template/template.go (right):
> 
>
http://codereview.appspot.com/5437147/diff/5001/src/pkg/html/template/templat...
> src/pkg/html/template/template.go:56: panic("html/template internal
> error: template escaping out of sync")
> i wonder if it might be worth still unlocking the mutex here - someone
> might catch the panic.

sure, although it is an internal error and things really are borked and
execution should stop. this is one case where panic makes sense: the guarantee
the package makes cannot be satisfied.

-rob

Expand All Messages | Collapse All Messages