Issue 5437140: Remove spurious spaces from music expression display, adapt tests.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5437140: Remove spurious spaces from music expression display, adapt tests. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by dak

Modified:
14 years ago

Reviewers:
carl.d.sorensen, lemzwerg

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Remove spurious spaces from music expression display, adapt tests.

Patch Set 1 #

Created: 14 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -37 lines)			Patch
	M	input/regression/display-lily-tests.ly	View		2 chunks	+31 lines, -31 lines	0 comments	Download
	M	scm/define-music-display-methods.scm	View		5 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

lemzwerg

David, I suggest to apply patches of that kind directly to the repository without setting ...

14 years ago (2011-12-06 05:39:42 UTC) #2

dak

14 years ago (2011-12-06 10:55:31 UTC) #3

On 2011/12/06 05:39:42, lemzwerg wrote:
> David, I suggest to apply patches of that kind directly to the repository
> without setting up a Rietveld issue.

Done.  It is actually part of my EventChord work.  I got oodles of display
difference due to all those spurious spaces differing in different contexts.  I
first aimed for bug compatibility, but then this got too crazy.

Anyway, pushed to staging.

Expand All Messages | Collapse All Messages