Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(17)

Issue 5437055: Record $ and # expressions inside of #{ #} for better correlation (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 10 months ago by dak
Modified:
7 years, 9 months ago
Reviewers:
pkx166h
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Record $ and # expressions inside of #{ #} for better correlation This improves and robustifies the closure handling of #{ ... #} and makes for proper error messages (well, the column display for the first line of #{ ... environments is missing the start of the line up to #{, but file and line number are ok). When the user managed to confuse Lilypond sufficiently that it has managed to preparse $ and # closures not actually in the source, Lilypond just reverts to interpreting the contents straight. This should fix issue 1356 to the degree where only extremely ugly input will cause problems.

Patch Set 1 #

Patch Set 2 : Don't create closures for obvious constants #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -45 lines) Patch
M lily/include/lily-parser.hh View 2 chunks +3 lines, -3 lines 0 comments Download
M lily/lily-parser.cc View 5 chunks +11 lines, -7 lines 0 comments Download
M lily/lily-parser-scheme.cc View 3 chunks +30 lines, -6 lines 0 comments Download
M lily/parse-scm.cc View 1 chunk +13 lines, -9 lines 0 comments Download
M lily/source-file.cc View 2 chunks +10 lines, -5 lines 0 comments Download
M scm/parser-ly-from-scheme.scm View 1 1 chunk +34 lines, -15 lines 0 comments Download

Messages

Total messages: 1
pkx166h
7 years, 10 months ago (2011-11-24 15:58:40 UTC) #1
passes make and make check

James
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b