Issue 5436069: code review 5436069: html: ignore <head> tags in <head> element

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5436069: code review 5436069: html: ignore <head> tags in <head> element (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by andybalholm

Modified:
13 years, 3 months ago

Reviewers:

CC:
nigeltao, golang-dev

Visibility:
Public.

Description

html: ignore <head> tags in <head> element Pass tests3.dat, test 12: <!DOCTYPE html><HTML><META><HEAD></HEAD></HTML> | <!DOCTYPE html> | <html> | <head> | <meta> | <body> Also pass tests through test 19: <!DOCTYPE html><html><head></head><body><ul><li><div><p><li></ul></body></html>

Patch Set 1 #

Patch Set 2 : diff -r 503e62ea3467 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 503e62ea3467 https://go.googlecode.com/hg/ #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	src/pkg/html/parse.go	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
	M	src/pkg/html/parse_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

andybalholm

Hello nigeltao@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 3 months ago (2011-11-26 16:25:20 UTC) #1

nigeltao

13 years, 3 months ago (2011-11-27 03:41:12 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=8dd8dc90dfc7 ***

html: ignore <head> tags in <head> element

Pass tests3.dat, test 12:
<!DOCTYPE html><HTML><META><HEAD></HEAD></HTML>

| <!DOCTYPE html>
| <html>
|   <head>
|     <meta>
|   <body>

Also pass tests through test 19:
<!DOCTYPE html><html><head></head><body><ul><li><div><p><li></ul></body></html>

R=nigeltao
CC=golang-dev
http://codereview.appspot.com/5436069

Committer: Nigel Tao <nigeltao@golang.org>

Expand All Messages | Collapse All Messages