Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(112)

Issue 5434093: code review 5434093: os/exec: make LookPath always search the current direct... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by bsiegert
Modified:
12 years, 4 months ago
Reviewers:
CC:
brainman, rsc, golang-dev
Visibility:
Public.

Description

os/exec: make LookPath always search the current directory under Windows. cmd.exe implicitly looks in "." before consulting PATH. LookPath should match this behavior.

Patch Set 1 #

Patch Set 2 : diff -r 1713e0b34111 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 1713e0b34111 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M src/pkg/os/exec/lp_windows.go View 1 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 4
bsiegert
Hello alex.brainman@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 4 months ago (2011-12-01 18:17:51 UTC) #1
brainman
Implementation LGTM, but I am not sure if LookPath suppose to behave like cmd.exe. Leaving ...
12 years, 4 months ago (2011-12-02 01:40:04 UTC) #2
rsc
Behaving like cmd.exe seems like a plausible goal. Certainly on Unix the goal is to ...
12 years, 4 months ago (2011-12-02 02:32:28 UTC) #3
brainman
12 years, 4 months ago (2011-12-02 03:29:31 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=a1fa68d06160 ***

os/exec: make LookPath always search the current directory under Windows.

cmd.exe implicitly looks in "." before consulting PATH.
LookPath should match this behavior.

R=alex.brainman, rsc
CC=golang-dev
http://codereview.appspot.com/5434093

Committer: Alex Brainman <alex.brainman@gmail.com>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b