Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(168)

Issue 54300049: Fixed to show Property Panel when the mode is auto hide. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 1 month ago by fujiwara
Modified:
10 years, 1 month ago
Reviewers:
shawn.p.huang, Peng
CC:
shawn.p.huang_gmail.com, fujiwara
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Fix to show Property Panel when the mode is auto hide. Property panel sometimes is not shown when the mode is auto hide and focus is changed between existent windows. It's a timing issue of PropertyPanel.set_properties().

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated with message #2. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -4 lines) Patch
M ui/gtk3/propertypanel.vala View 1 4 chunks +21 lines, -4 lines 0 comments Download

Messages

Total messages: 3
fujiwara
10 years, 1 month ago (2014-02-07 08:26:40 UTC) #1
Peng
lgtm https://codereview.appspot.com/54300049/diff/1/ui/gtk3/propertypanel.vala File ui/gtk3/propertypanel.vala (right): https://codereview.appspot.com/54300049/diff/1/ui/gtk3/propertypanel.vala#newcode73 ui/gtk3/propertypanel.vala:73: */ Could you please merge two comment blocks ...
10 years, 1 month ago (2014-02-07 16:04:59 UTC) #2
fujiwara
10 years, 1 month ago (2014-02-10 02:55:15 UTC) #3
https://codereview.appspot.com/54300049/diff/1/ui/gtk3/propertypanel.vala
File ui/gtk3/propertypanel.vala (right):

https://codereview.appspot.com/54300049/diff/1/ui/gtk3/propertypanel.vala#new...
ui/gtk3/propertypanel.vala:73: */
On 2014/02/07 16:05:00, Peng wrote:
> Could you please merge two comment blocks to one. 

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b