Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(63)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 5427043: UrlEncodedContent.getContent and don't allow null data (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years ago by yanivi
Modified:
14 years ago
Reviewers:
rmistry
Base URL:
https://code.google.com/p/google-http-java-client/
Visibility:
Public.

Patch Set 1 #

Total comments: 4

Patch Set 2 : based on feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -10 lines) Patch
M google-http-client/src/main/java/com/google/api/client/http/BasicAuthentication.java View 2 chunks +4 lines, -2 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/http/HttpHeaders.java View 2 chunks +4 lines, -2 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/http/UrlEncodedContent.java View 1 5 chunks +73 lines, -6 lines 0 comments Download
M google-http-client/src/test/java/com/google/api/client/http/UrlEncodedContentTest.java View 1 3 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 5
yanivi
14 years ago (2011-11-21 22:11:22 UTC) #1
rmistry
http://codereview.appspot.com/5427043/diff/1/google-http-client/src/main/java/com/google/api/client/http/UrlEncodedContent.java File google-http-client/src/main/java/com/google/api/client/http/UrlEncodedContent.java (right): http://codereview.appspot.com/5427043/diff/1/google-http-client/src/main/java/com/google/api/client/http/UrlEncodedContent.java#newcode133 google-http-client/src/main/java/com/google/api/client/http/UrlEncodedContent.java:133: public Object getOrInitializeData() { Why not just call this ...
14 years ago (2011-11-21 22:21:15 UTC) #2
yanivi
http://codereview.appspot.com/5427043/diff/1/google-http-client/src/main/java/com/google/api/client/http/UrlEncodedContent.java File google-http-client/src/main/java/com/google/api/client/http/UrlEncodedContent.java (right): http://codereview.appspot.com/5427043/diff/1/google-http-client/src/main/java/com/google/api/client/http/UrlEncodedContent.java#newcode133 google-http-client/src/main/java/com/google/api/client/http/UrlEncodedContent.java:133: public Object getOrInitializeData() { On 2011/11/21 22:21:15, rmistry wrote: ...
14 years ago (2011-11-22 15:57:08 UTC) #3
rmistry
LGTM If you do not mind lets wait to submit this till we figure out ...
14 years ago (2011-11-22 16:30:24 UTC) #4
yanivi
14 years ago (2011-11-22 16:46:57 UTC) #5 
On 2011/11/22 16:30:24, rmistry wrote:
> LGTM
> 
> If you do not mind lets wait to submit this till we figure out the sync issue.

As we discussed, I'll check this in now so we are not blocked on any internal
sync issues.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b