Issue 54240044: Enable loading Picker API via gapi.load.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 54240044: Enable loading Picker API via gapi.load. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by kpreid2

Modified:
12 years, 1 month ago

Reviewers:
ihab.awad

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

* Support "gapi.load('picker', ...)" as given in the example at <https://developers.google.com/picker/docs/#hiworld>. It is unclear (from public documentation) what the structure of the loadable APIs actually is, so for now just add a special case which points at the 'google.picker' policy name. * Refactor loader API name validation to be in one place. * Increase URL length limit in test server, allowing larger test content to be used in generic-host-page. @r5658

Patch Set 1 #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+67 lines, -35 lines)			Patch
M	src/com/google/caja/apitaming/cajaTamingGoogleLoader.js	View	3 chunks	+16 lines, -6 lines	0 comments	Download
M	src/com/google/caja/apitaming/gapi.client.load.loaderFactory.js	View	2 chunks	+37 lines, -16 lines	0 comments	Download
M	src/com/google/caja/apitaming/google.load.loaderFactory.js	View	2 chunks	+9 lines, -13 lines	0 comments	Download
M	tests/com/google/caja/util/LocalServer.java	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

lgtm

Expand All Messages | Collapse All Messages