state: deprecate JobManageState

state/machine_test.go

 // Copyright 2012, 2013 Canonical Ltd.
 // Licensed under the AGPLv3, see LICENCE file for details.
 
 package state_test
 
 import (
         "sort"
 
         gc "launchpad.net/gocheck"
 
@@ skipping 399 matching lines @@
 
         m, err := s.State.Machine(s.machine.Id())
         c.Assert(err, gc.IsNil)
         id, err := m.InstanceId()
         c.Assert(err, gc.IsNil)
         c.Assert(string(id), gc.Equals, "umbrella/0")
         c.Assert(s.machine.CheckProvisioned("fake_nonce"), gc.Equals, true)
         // Clear the deprecated machineDoc InstanceId attribute and ensure that CheckProvisioned()
         // still works as expected with the new data model.
         state.SetMachineInstanceId(s.machine, "")
+        id, err = s.machine.InstanceId()
+        c.Assert(err, gc.IsNil)
+        c.Assert(string(id), gc.Equals, "umbrella/0")
         c.Assert(s.machine.CheckProvisioned("fake_nonce"), gc.Equals, true)
 
         // Try it twice, it should fail.
         err = s.machine.SetProvisioned("doesn't-matter", "phony", nil)
         c.Assert(err, gc.ErrorMatches, `cannot set instance data for machine "0": already set`)
 
         // Check it with invalid nonce.
         c.Assert(s.machine.CheckProvisioned("not-really"), gc.Equals, false)
 }
 
 func (s *MachineSuite) TestMachineSetProvisionedWhenNotAlive(c *gc.C) {
         testWhenDying(c, s.machine, notAliveErr, notAliveErr, func() error {
                 return s.machine.SetProvisioned("umbrella/0", "fake_nonce", nil)
         })
+}
+
+func (s *MachineSuite) TestMachineSetInstanceStatus(c *gc.C) {
+        // Machine needs to be provisioned first.
+        err := s.machine.SetProvisioned("umbrella/0", "fake_nonce", nil)
+        c.Assert(err, gc.IsNil)
+
+        err = s.machine.SetInstanceStatus("ALIVE")
+        c.Assert(err, gc.IsNil)
+
+        // Reload machine and check result.
+        err = s.machine.Refresh()
+        c.Assert(err, gc.IsNil)
+        status, err := s.machine.InstanceStatus()
+        c.Assert(err, gc.IsNil)
+        c.Assert(status, gc.DeepEquals, "ALIVE")
+}
+
+func (s *MachineSuite) TestNotProvisionedMachineSetInstanceStatus(c *gc.C) {
+        err := s.machine.SetInstanceStatus("ALIVE")
+        c.Assert(err, gc.ErrorMatches, ".* not provisioned")
+}
+
+func (s *MachineSuite) TestNotProvisionedMachineInstanceStatus(c *gc.C) {
+        _, err := s.machine.InstanceStatus()
+        c.Assert(err, jc.Satisfies, state.IsNotProvisionedError)
+}
+
+// SCHEMACHANGE
+func (s *MachineSuite) TestInstanceStatusOldSchema(c *gc.C) {
+        // Machine needs to be provisioned first.
+        err := s.machine.SetProvisioned("umbrella/0", "fake_nonce", nil)
+        c.Assert(err, gc.IsNil)
+
+        // Remove the InstanceId from instanceData doc to simulate an old schema.
+        state.ClearInstanceDocId(c, s.machine)
+
+        err = s.machine.SetInstanceStatus("ALIVE")
+        c.Assert(err, gc.IsNil)
+
+        // Reload machine and check result.
+        err = s.machine.Refresh()
+        c.Assert(err, gc.IsNil)
+        status, err := s.machine.InstanceStatus()
+        c.Assert(err, gc.IsNil)
+        c.Assert(status, gc.DeepEquals, "ALIVE")
 }
 
 func (s *MachineSuite) TestMachineRefresh(c *gc.C) {
         m0, err := s.State.AddMachine("quantal", state.JobHostUnits)
         c.Assert(err, gc.IsNil)
         oldTools, _ := m0.AgentTools()
         m1, err := s.State.Machine(m0.Id())
         c.Assert(err, gc.IsNil)
         err = m0.SetAgentVersion(version.MustParseBinary("0.0.3-series-arch"))
         c.Assert(err, gc.IsNil)
@@ skipping 835 matching lines @@
                 err = container.Refresh()
                 c.Assert(err, gc.IsNil)
                 status, info, data, err := container.Status()
                 c.Assert(err, gc.IsNil)
                 c.Assert(status, gc.Equals, params.StatusError)
                 c.Assert(info, gc.Equals, "unsupported container")
                 containerType := state.ContainerTypeFromId(container.Id())
                 c.Assert(data, gc.DeepEquals, params.StatusData{"type": string(containerType)})
         }
 }