Issue 5422043: code review 5422043: html: ignore whitespace before <head> element

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5422043: code review 5422043: html: ignore whitespace before <head> element (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by andybalholm

Modified:
13 years, 3 months ago

Reviewers:

CC:
nigeltao, golang-dev

Visibility:
Public.

Description

html: ignore whitespace before <head> element Pass tests2.dat, test 47: " \n " (That is, two spaces separated by a newline) | <html> | <head> | <body> Also pass tests through test 49: <!DOCTYPE html><script> </script> <title>x</title> </head>

Patch Set 1 #

Patch Set 2 : diff -r d1853f7ec1c7 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r d1853f7ec1c7 https://go.googlecode.com/hg/ #

Total comments: 1

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -2 lines)			Patch
	M	src/pkg/html/parse.go	View	1	3 chunks	+17 lines, -1 line	1 comment	Download
	M	src/pkg/html/parse_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

andybalholm

Hello nigeltao@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 3 months ago (2011-11-21 17:31:32 UTC) #1

nigeltao

LGTM, submitting. http://codereview.appspot.com/5422043/diff/4001/src/pkg/html/parse.go File src/pkg/html/parse.go (right): http://codereview.appspot.com/5422043/diff/4001/src/pkg/html/parse.go#newcode338 src/pkg/html/parse.go:338: case TextToken: I'd move this case to ...

13 years, 3 months ago (2011-11-21 22:25:25 UTC) #2

nigeltao

13 years, 3 months ago (2011-11-21 22:27:12 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=a7293a22335c ***

html: ignore whitespace before <head> element

Pass tests2.dat, test 47:
" \n "
(That is, two spaces separated by a newline)

| <html>
|   <head>
|   <body>

Also pass tests through test 49:
<!DOCTYPE html><script>
</script>  <title>x</title>  </head>

R=nigeltao
CC=golang-dev
http://codereview.appspot.com/5422043

Committer: Nigel Tao <nigeltao@golang.org>

Expand All Messages | Collapse All Messages