code review 5420051: oauth: Add a public method to renew tokens.

oauth: Add a public method to renew tokens.

[manugarg1, 2011-11-21 11:10:38]

Hello adg@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/goauth2/

[adg, 2011-11-21 22:42:13]

http://codereview.appspot.com/5420051/diff/1003/oauth/oauth.go
File oauth/oauth.go (right):

http://codereview.appspot.com/5420051/diff/1003/oauth/oauth.go#newcode187
oauth/oauth.go:187: // RenewToken renews the Token using Refresh Token.
Let's just call this "Refresh" (like "Exchange").

// Refresh refreshes the Transport's AccessToken using its RefreshToken.

http://codereview.appspot.com/5420051/diff/1003/oauth/oauth.go#newcode188
oauth/oauth.go:188: // If the Token cannot be renewed a non-nil os.Error is
returned.
drop this line, it's obvious

http://codereview.appspot.com/5420051/diff/1003/oauth/oauth.go#newcode196
oauth/oauth.go:196: // Update the Token
drop this comment, it's obvious

http://codereview.appspot.com/5420051/diff/1003/oauth/oauth.go#newcode198
oauth/oauth.go:198: "grant_type":	{"refresh_token"},
please run gofmt on this file

[manugarg1, 2011-11-22 02:35:43]

Hello adg@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[adg, 2011-11-22 03:07:11]

Looking good. Sorry, I'm picky about language.

http://codereview.appspot.com/5420051/diff/7001/oauth/oauth.go
File oauth/oauth.go (right):

http://codereview.appspot.com/5420051/diff/7001/oauth/oauth.go#newcode187
oauth/oauth.go:187: // Refresh renews the Token using Refresh Token.
Please use the language I provided:
// Refresh renews the Transport's AccessToken using its RefreshToken.

[manugarg1, 2011-11-22 03:14:27]

Hello adg@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[adg, 2011-11-22 03:23:52]

LGTM

[adg, 2011-11-22 03:27:35]

*** Submitted as http://code.google.com/p/goauth2/source/detail?r=937479bfc9e1
***

oauth: Add a public method to renew tokens.

R=adg
CC=golang-dev
http://codereview.appspot.com/5420051

Committer: Andrew Gerrand <adg@golang.org>