DirectWrite font host for skia.

To build with DirectWrite font host use

python gyp_skia -Dskia_use_dw=true

or equivalent to create your projects.

Note that this is still rather rough, but does represent what should be the final approach to getting this working in skia.

[bungeman, 2012-01-13 21:24:35]

While there are some things left to do, I believe this has reached feature
parity with the GDI font host, so review away.

[Steve VanDeBogart, 2012-01-13 21:29:36]

http://codereview.appspot.com/5417063/diff/24001/src/core/SkAdvancedTypefaceM...
File src/core/SkAdvancedTypefaceMetrics.cpp (right):

http://codereview.appspot.com/5417063/diff/24001/src/core/SkAdvancedTypefaceM...
src/core/SkAdvancedTypefaceMetrics.cpp:283: const uint32_t* subsetGlyphIDs,k
stray character

[bungeman, 2012-01-13 21:37:35]

http://codereview.appspot.com/5417063/diff/24001/src/core/SkAdvancedTypefaceM...
File src/core/SkAdvancedTypefaceMetrics.cpp (right):

http://codereview.appspot.com/5417063/diff/24001/src/core/SkAdvancedTypefaceM...
src/core/SkAdvancedTypefaceMetrics.cpp:283: const uint32_t* subsetGlyphIDs,k
On 2012/01/13 21:29:37, Steve VanDeBogart wrote:
> stray character

Done.

Not sure how that got in there.

[reed1, 2012-01-13 21:58:06]

lgmt, with an eye toward future reorg around sfnt/opentype headers and utilities

http://codereview.appspot.com/5417063/diff/22018/include/core/SkEndian.h
File include/core/SkEndian.h (right):

http://codereview.appspot.com/5417063/diff/22018/include/core/SkEndian.h#newc...
include/core/SkEndian.h:62: template<uint32_t N>
all on same line in skia

template<> struct ...

http://codereview.appspot.com/5417063/diff/22018/samplecode/SampleTextBox.cpp
File samplecode/SampleTextBox.cpp (right):

http://codereview.appspot.com/5417063/diff/22018/samplecode/SampleTextBox.cpp...
samplecode/SampleTextBox.cpp:101: if (fRight) {
alt: fSubOffset += SK_Scalar1 / 4;

[bungeman, 2012-01-13 22:10:29]

http://codereview.appspot.com/5417063/diff/22018/include/core/SkEndian.h
File include/core/SkEndian.h (right):

http://codereview.appspot.com/5417063/diff/22018/include/core/SkEndian.h#newc...
include/core/SkEndian.h:62: template<uint32_t N>
On 2012/01/13 21:58:07, reed1 wrote:
> all on same line in skia
> 
> template<> struct ...

Done.

http://codereview.appspot.com/5417063/diff/22018/samplecode/SampleTextBox.cpp
File samplecode/SampleTextBox.cpp (right):

http://codereview.appspot.com/5417063/diff/22018/samplecode/SampleTextBox.cpp...
samplecode/SampleTextBox.cpp:101: if (fRight) {
On 2012/01/13 21:58:07, reed1 wrote:
> alt: fSubOffset += SK_Scalar1 / 4;

Done. Twice.

[bungeman, 2012-08-01 19:23:36]

Now considered more or less feature complete.

[reed1, 2012-08-01 19:36:45]

I see a lot of new files that are "utilities" for win. Are these actually just
utils for SkFontHost_win_dw.cpp ? If so, can/should we create a dir just for
that for now?

https://codereview.appspot.com/5417063/diff/39001/src/utils/SkFloatUtils.h
File src/utils/SkFloatUtils.h (right):

https://codereview.appspot.com/5417063/diff/39001/src/utils/SkFloatUtils.h#ne...
src/utils/SkFloatUtils.h:6: */
Can this file live in src/utils/win for now? This is a lot of general-looking
stuff, and it might be all wonderful, but its a lot more surface area that we
didn't have/need previously, and I want to contain it initially.

[reed1, 2012-08-01 19:37:24]

Do we really need a global SK_USE_DW compile flag? Can the GDI/DW distinction be
strictly an issue for the makefiles?

[bungeman, 2012-08-01 20:58:30]

The two new utils are SkDWriteFontFileStream.h and SkDWriteToPath.h, and they
aren't aware of font host things, which is why they were moved out.

SkDWriteFontFileStream declares SkIDWriteFontFileStream and
SkIDWriteFontFileStreamWrapper which are just wrappers around DirectWrite
streams so they can be viewed as SkStreams.

SkDWriteToPath is actually very general as it is an (almost) complete
DirectWrite/D2D geometry sink. The name is somewhat misleading as it's actually
a D2D geometry sink, DirectWrite just typedefs it over.

These are the only ones added to 'win', and they are more 'win' than 'font
hosty', so I'm not sure they really need yet another directory (considering
'utils/win' only has a total of 6 items, including these). I'd prefer not to
have them in 'ports' since they're not really ports of anything in core. Is
there a better place?


SK_USE_DW only exists because of SkAdvancedTypefaceMetrics. I will change the
name to something more descriptive, like SK_FONTHOST_WIN_DW and make cleaning up
SkAdvancedTypefaceMetrics a priority, since it is preventing runtime switching
of font hosts.

https://codereview.appspot.com/5417063/diff/39001/src/utils/SkFloatUtils.h
File src/utils/SkFloatUtils.h (right):

https://codereview.appspot.com/5417063/diff/39001/src/utils/SkFloatUtils.h#ne...
src/utils/SkFloatUtils.h:6: */
On 2012/08/01 19:36:45, reed1 wrote:
> Can this file live in src/utils/win for now? This is a lot of general-looking
> stuff, and it might be all wonderful, but its a lot more surface area that we
> didn't have/need previously, and I want to contain it initially.

We could, but Cary already has expressed a need for such a thing as this, and
has one in experimental.

[bungeman, 2012-08-16 16:01:19]

The new headers are now in src instead of include, and the naming has been
simplified.

http://code.google.com/p/skia/issues/detail?id=787 has been opened for the
removal of fonthost build time defines.

[reed1, 2012-08-16 16:02:54]

lgtm

[bungeman, 2012-08-16 16:15:32]

Committed revision 5128.

Note that the way to build with DirectWrite on Windows for the time being is to
specify

python gyp_skia -Dskia_directwrite=1