Issue 5417053: code review 5417053: go/printer: cleanup more string/byte conversions

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5417053: code review 5417053: go/printer: cleanup more string/byte conversions (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by gri

Modified:
13 years, 3 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

go/printer: cleanup more string/byte conversions Slight slow-down for printer benchmark (-0.7%) before applying CL 5416049 (which will wash it out). Code is cleaner and simpler.

Patch Set 2 : diff -r cbadf4cb44e4 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r cbadf4cb44e4 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 4ed397e2cef1 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r f7946212daf9 https://go.googlecode.com/hg/ #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -39 lines)			Patch
	M	src/pkg/go/printer/printer.go	View	1 2 3	19 chunks	+30 lines, -39 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gri

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 3 months ago (2011-11-19 01:31:04 UTC) #1

rsc

LGTM http://codereview.appspot.com/5417053/diff/1002/src/pkg/go/printer/printer.go File src/pkg/go/printer/printer.go (right): http://codereview.appspot.com/5417053/diff/1002/src/pkg/go/printer/printer.go#newcode139 src/pkg/go/printer/printer.go:139: n, err := p.output.Write([]byte(data)) if you use io.WriteString(p.output, ...

13 years, 3 months ago (2011-11-19 02:59:28 UTC) #2

gri

On Fri, Nov 18, 2011 at 6:59 PM, <rsc@golang.org> wrote: > LGTM > > > ...

13 years, 3 months ago (2011-11-19 04:54:12 UTC) #3

gri

13 years, 3 months ago (2011-11-19 04:55:39 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=e60b5b62cd79 ***

go/printer: cleanup more string/byte conversions

Slight slow-down for printer benchmark (-0.7%) before
applying CL 5416049 (which will wash it out). Code is
cleaner and simpler.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5417053

Expand All Messages | Collapse All Messages