Issue 54130043: Pty write support in connect_write_pipe.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 54130043: Pty write support in connect_write_pipe. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 4 months ago by jonathan.slenders

Modified:
10 years, 3 months ago

Reviewers:
GvR, jonathan

Visibility:
Public.

More Reviews

Description

Pty write support in connect_write_pipe.

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -1 line)			Patch
	M	asyncio/unix_events.py	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	tests/test_events.py	View		1 chunk	+47 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

jonathan_slenders.be

10 years, 3 months ago (2014-01-29 18:45:29 UTC) #2

Nope. You can close that.

Victor merged it here:
https://code.google.com/p/tulip/source/detail?r=d5986dcbef0ba43a9cdd1cf6e5c07...

Thanks!



2014-01-29 <gvanrossum@gmail.com>

> I apologize, I lost track of this. Is this still needed?
>
> https://codereview.appspot.com/54130043/
>

Expand All Messages | Collapse All Messages