Issue 5399049: code review 5399049: html: parse <isindex>

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5399049: code review 5399049: html: parse <isindex> (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by andybalholm

Modified:
13 years, 4 months ago

Reviewers:

CC:
nigeltao, golang-dev

Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : diff -r 2b24fa6cd9d7 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 2b24fa6cd9d7 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 2b24fa6cd9d7 https://go.googlecode.com/hg/ #

Total comments: 1

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -1 line)			Patch
	M	src/pkg/html/parse.go	View	1 2 3	1 chunk	+38 lines, -0 lines	1 comment	Download
	M	src/pkg/html/parse_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

andybalholm

Hello nigeltao@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 4 months ago (2011-11-17 01:20:02 UTC) #1

andybalholm

Hello nigeltao@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 4 months ago (2011-11-17 02:04:36 UTC) #2

nigeltao

LGTM. http://codereview.appspot.com/5399049/diff/6001/src/pkg/html/parse.go File src/pkg/html/parse.go (right): http://codereview.appspot.com/5399049/diff/6001/src/pkg/html/parse.go#newcode686 src/pkg/html/parse.go:686: case "isindex": Wow! This tag is terrible.

13 years, 4 months ago (2011-11-17 02:11:00 UTC) #3

nigeltao

*** Submitted as http://code.google.com/p/go/source/detail?r=da9e7548e6ef *** html: parse <isindex> Pass tests2.dat, test 42: <isindex test=x name=x> ...

13 years, 4 months ago (2011-11-17 02:12:03 UTC) #4

andybalholm

13 years, 4 months ago (2011-11-17 16:12:25 UTC) #5

On Nov 16, 2011, at 6:11 PM, nigeltao@golang.org wrote:

> Wow! This tag is terrible.

And most likely the list of sites we'll encounter that actually use it is
shorter than the code to parse it.

Expand All Messages | Collapse All Messages