code review 5395052: exp/ssh: fix test?

exp/ssh: fix test?

Fixes use of c after Dial failure (causes crash).
May fix Dial failure by listening to 127.0.0.1:0
instead of 0.0.0.0:0 (tests should only listen on
localhost).

[rsc, 2011-11-16 23:11:16]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg

[gri, 2011-11-16 23:12:38]

LGTM

On Wed, Nov 16, 2011 at 3:11 PM,  <rsc@golang.org> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg
>
>
> Description:
> exp/ssh: fix test?
>
> Fixes use of c after Dial failure (causes crash).
> May fix Dial failure by listening to 127.0.0.1:0
> instead of 0.0.0.0:0 (tests should only listen on
> localhost).
>
> Please review this at http://codereview.appspot.com/5395052/
>
> Affected files:
>  M src/pkg/exp/ssh/client_auth_test.go
>
>
> Index: src/pkg/exp/ssh/client_auth_test.go
> ===================================================================
> --- a/src/pkg/exp/ssh/client_auth_test.go
> +++ b/src/pkg/exp/ssh/client_auth_test.go
> @@ -112,22 +112,22 @@
>        }
>        serverConfig.PasswordCallback = nil
>
> -       l, err := Listen("tcp", "0.0.0.0:0", serverConfig)
> +       l, err := Listen("tcp", "127.0.0.1:0", serverConfig)
>        if err != nil {
>                t.Fatalf("unable to listen: %s", err)
>        }
>        defer l.Close()
>
> -       done := make(chan bool)
> +       done := make(chan bool, 1)
>        go func() {
>                c, err := l.Accept()
>                if err != nil {
>                        t.Fatal(err)
>                }
> +               defer c.Close()
>                if err := c.Handshake(); err != nil {
>                        t.Error(err)
>                }
> -               defer c.Close()
>                done <- true
>        }()
>
> @@ -140,7 +140,7 @@
>
>        c, err := Dial("tcp", l.Addr().String(), config)
>        if err != nil {
> -               t.Errorf("unable to dial remote side: %s", err)
> +               t.Fatalf("unable to dial remote side: %s", err)
>        }
>        defer c.Close()
>        <-done
>
>
>

[rsc, 2011-11-16 23:13:55]

*** Submitted as http://code.google.com/p/go/source/detail?r=3000644f866a ***

exp/ssh: fix test?

Fixes use of c after Dial failure (causes crash).
May fix Dial failure by listening to 127.0.0.1:0
instead of 0.0.0.0:0 (tests should only listen on
localhost).

R=golang-dev, gri
CC=golang-dev
http://codereview.appspot.com/5395052

[dave_cheney.net, 2011-11-17 00:39:24]

Thanks Russ.

On Thu, Nov 17, 2011 at 10:13 AM,  <rsc@golang.org> wrote:
> *** Submitted as
> http://code.google.com/p/go/source/detail?r=3000644f866a ***
>
> exp/ssh: fix test?
>
> Fixes use of c after Dial failure (causes crash).
> May fix Dial failure by listening to 127.0.0.1:0
> instead of 0.0.0.0:0 (tests should only listen on
> localhost).
>
> R=golang-dev, gri
> CC=golang-dev
> http://codereview.appspot.com/5395052
>
>
> http://codereview.appspot.com/5395052/
>