Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(193)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 5395045: code review 5395045: html: parse </optgroup> and </option> (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by andybalholm
Modified:
13 years, 4 months ago
Reviewers:
CC:
nigeltao, rsc, golang-dev
Visibility:
Public.

Description

html: parse </optgroup> and </option> Pass tests2.dat, test 35: <!DOCTYPE html><select><optgroup><option></optgroup><option><select><option> | <!DOCTYPE html> | <html> | <head> | <body> | <select> | <optgroup> | <option> | <option> | <option> Also pass tests through test 41: <!DOCTYPE html><!-- XXX - XXX - XXX -->

Patch Set 1 #

Patch Set 2 : diff -r cb2b19aa807b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r cb2b19aa807b https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M src/pkg/html/parse.go View 1 1 chunk +10 lines, -2 lines 0 comments Download
M src/pkg/html/parse_test.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
andybalholm
Hello nigeltao@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 4 months ago (2011-11-16 16:27:09 UTC) #1
rsc
Thanks for all your hard work. It's great to see this chugging along. If you ...
13 years, 4 months ago (2011-11-16 19:58:07 UTC) #2
nigeltao
LGTM.
13 years, 4 months ago (2011-11-16 23:24:52 UTC) #3
nigeltao
*** Submitted as http://code.google.com/p/go/source/detail?r=883f9c167138 *** html: parse </optgroup> and </option> Pass tests2.dat, test 35: <!DOCTYPE ...
13 years, 4 months ago (2011-11-16 23:25:20 UTC) #4
nigeltao
On 17 November 2011 06:58, Russ Cox <rsc@golang.org> wrote: > Thanks for all your hard ...
13 years, 4 months ago (2011-11-16 23:34:49 UTC) #5
andybalholm
13 years, 4 months ago (2011-11-17 01:00:04 UTC) #6 
On Nov 16, 2011, at 3:34 PM, Nigel Tao wrote:

> On 17 November 2011 06:58, Russ Cox <rsc@golang.org> wrote:
>> Thanks for all your hard work.  It's great to see
>> this chugging along.
> 
> I'm also very happy to see these patches. It literally makes me get up
> earlier in the morning than I otherwise would, even when I'm meant to
> be on vacation. :-)

Sometimes that means that I can get two fixes done in a day.

>> If you consistently fix one HTML tag per day,
>> how many years will it take to reach HTML5?  :-)
> 
> Well, the meme used to be "HTML5 won't be finalized until 2022"...

Hopefully we can get done by then.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b