Issue 5394046: code review 5394046: fcgi: fix server capability discovery

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5394046: code review 5394046: fcgi: fix server capability discovery (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by bradfitz

Modified:
13 years, 4 months ago

Reviewers:

CC:
golang-dev, eds2

Visibility:
Public.

Description

fcgi: fix server capability discovery The wrong length was being sent, and two parameters were also transposed. Made the record type be a type and made the constants typed, to prevent that sort of bug in the future. Fixes issue 2469

Patch Set 1 #

Patch Set 2 : diff -r 69a3bac021b1 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 69a3bac021b1 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 539d058e9b0a https://go.googlecode.com/hg/ #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+143 lines, -90 lines)			Patch
M	src/pkg/net/http/fcgi/child.go	View	1	2 chunks	+79 lines, -66 lines	0 comments	Download
M	src/pkg/net/http/fcgi/fcgi.go	View	1	7 chunks	+22 lines, -19 lines	0 comments	Download
M	src/pkg/net/http/fcgi/fcgi_test.go	View	1	3 chunks	+42 lines, -5 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 4 months ago (2011-11-16 17:53:48 UTC) #1

bradfitz

13 years, 4 months ago (2011-11-16 18:11:43 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=5aa4a77d698d ***

fcgi: fix server capability discovery

The wrong length was being sent, and two parameters
were also transposed. Made the record type be a type
and made the constants typed, to prevent that sort
of bug in the future.

Fixes issue 2469

R=golang-dev, edsrzf
CC=golang-dev
http://codereview.appspot.com/5394046

Expand All Messages | Collapse All Messages