src/pkg/html/parse.go - Issue 5393045: code review 5393045: html: parse <optgroup> tags

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/pkg/html/parse.go

Issue 5393045: code review 5393045: html: parse <optgroup> tags (Closed)

Patch Set: diff -r 44246cae3737 https://go.googlecode.com/hg/ Created 13 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/pkg/html/parse.go

===================================================================

--- a/src/pkg/html/parse.go

+++ b/src/pkg/html/parse.go

@@ -1226,7 +1226,13 @@

}

p.addElement(p.tok.Data, p.tok.Attr)

case "optgroup":

- // TODO.

+ if p.top().Data == "option" {

+ p.oe.pop()

+ }

+ if p.top().Data == "optgroup" {

+ p.oe.pop()

+ }

+ p.addElement(p.tok.Data, p.tok.Attr)

case "select":

endSelect = true

case "input", "keygen", "textarea":

« no previous file with comments | « no previous file | src/pkg/html/parse_test.go » ('j') | no next file with comments »