Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1)

Delta Between Two Patch Sets: src/pkg/html/parse.go

Issue 5393045: code review 5393045: html: parse <optgroup> tags (Closed)
Left Patch Set: Created 13 years, 4 months ago
Right Patch Set: diff -r 44246cae3737 https://go.googlecode.com/hg/ Created 13 years, 4 months ago
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | src/pkg/html/parse_test.go » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
(no file at all)
1 // Copyright 2010 The Go Authors. All rights reserved. 1 // Copyright 2010 The Go Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style 2 // Use of this source code is governed by a BSD-style
3 // license that can be found in the LICENSE file. 3 // license that can be found in the LICENSE file.
4 4
5 package html 5 package html
6 6
7 import ( 7 import (
8 "io" 8 "io"
9 "strings" 9 "strings"
10 ) 10 )
(...skipping 1208 matching lines...) Expand 10 before | Expand all | Expand 10 after
1219 case StartTagToken: 1219 case StartTagToken:
1220 switch p.tok.Data { 1220 switch p.tok.Data {
1221 case "html": 1221 case "html":
1222 // TODO. 1222 // TODO.
1223 case "option": 1223 case "option":
1224 if p.top().Data == "option" { 1224 if p.top().Data == "option" {
1225 p.oe.pop() 1225 p.oe.pop()
1226 } 1226 }
1227 p.addElement(p.tok.Data, p.tok.Attr) 1227 p.addElement(p.tok.Data, p.tok.Attr)
1228 case "optgroup": 1228 case "optgroup":
1229 » » » // TODO. 1229 » » » if p.top().Data == "option" {
1230 » » » » p.oe.pop()
1231 » » » }
1232 » » » if p.top().Data == "optgroup" {
1233 » » » » p.oe.pop()
1234 » » » }
1235 » » » p.addElement(p.tok.Data, p.tok.Attr)
1230 case "select": 1236 case "select":
1231 endSelect = true 1237 endSelect = true
1232 case "input", "keygen", "textarea": 1238 case "input", "keygen", "textarea":
1233 // TODO. 1239 // TODO.
1234 case "script": 1240 case "script":
1235 // TODO. 1241 // TODO.
1236 default: 1242 default:
1237 // Ignore the token. 1243 // Ignore the token.
1238 } 1244 }
1239 case EndTagToken: 1245 case EndTagToken:
(...skipping 196 matching lines...) Expand 10 before | Expand all | Expand 10 after
1436 consumed = p.im(p) 1442 consumed = p.im(p)
1437 } 1443 }
1438 // Loop until the final token (the ErrorToken signifying EOF) is consume d. 1444 // Loop until the final token (the ErrorToken signifying EOF) is consume d.
1439 for { 1445 for {
1440 if consumed = p.im(p); consumed { 1446 if consumed = p.im(p); consumed {
1441 break 1447 break
1442 } 1448 }
1443 } 1449 }
1444 return p.doc, nil 1450 return p.doc, nil
1445 } 1451 }
LEFTRIGHT

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b