Issue 5387041: code review 5387041: encoding/json: add marshal/unmarshal benchmark

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5387041: code review 5387041: encoding/json: add marshal/unmarshal benchmark (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by rsc

Modified:
13 years, 4 months ago

Reviewers:

CC:
bradfitz, golang-dev

Visibility:
Public.

Description

encoding/json: add marshal/unmarshal benchmark

Patch Set 2 : diff -r 46d308546a72 https://go.googlecode.com/hg #

Patch Set 3 : diff -r 46d308546a72 https://go.googlecode.com/hg #

Total comments: 2

Patch Set 4 : diff -r be4d7ed4ed68 https://go.googlecode.com/hg #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+157 lines, -0 lines)			Patch
	A	src/pkg/encoding/json/bench_test.go	View	1 2 3	1 chunk	+157 lines, -0 lines	0 comments	Download
	A	src/pkg/encoding/json/testdata/code.json.gz	View	1 2	Binary file		0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello bradfitz (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg

13 years, 4 months ago (2011-11-14 20:49:29 UTC) #1

bradfitz

LGTM http://codereview.appspot.com/5387041/diff/4001/src/pkg/encoding/json/bench_test.go File src/pkg/encoding/json/bench_test.go (right): http://codereview.appspot.com/5387041/diff/4001/src/pkg/encoding/json/bench_test.go#newcode101 src/pkg/encoding/json/bench_test.go:101: var r codeResponse I might declare this before ...

13 years, 4 months ago (2011-11-14 21:17:09 UTC) #2

rsc

13 years, 4 months ago (2011-11-15 15:58:27 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=7d46b8d2b542 ***

encoding/json: add marshal/unmarshal benchmark

R=bradfitz
CC=golang-dev
http://codereview.appspot.com/5387041

Expand All Messages | Collapse All Messages