Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(818)

Issue 53810045: state/apiserver: no need for Client ping

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by rog
Modified:
10 years, 3 months ago
Reviewers:
mp+202162, natefinch
Visibility:
Public.

Description

state/apiserver: no need for Client ping If a Client connection didn't ping, the connection shut down after 3 minutes. This led to bug #1269519. Since the only reason for this behaviour is to maintain the agent liveness status, we gate it on that, so clients will have no need to ping. https://code.launchpad.net/~rogpeppe/juju-core/486-client-no-need-to-ping/+merge/202162 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state/apiserver: no need for Client ping #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -15 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M state/apiserver/admin.go View 1 chunk +9 lines, -1 line 0 comments Download
M state/apiserver/export_test.go View 1 chunk +1 line, -0 lines 0 comments Download
M state/apiserver/pinger_test.go View 3 chunks +20 lines, -5 lines 0 comments Download
M state/apiserver/root.go View 4 chunks +11 lines, -9 lines 0 comments Download

Messages

Total messages: 2
natefinch
LGTM
10 years, 3 months ago (2014-01-17 19:48:22 UTC) #1
rog
10 years, 3 months ago (2014-01-17 19:51:35 UTC) #2
Please take a look.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b