code review 5376099: net/http: fix build

net/http: fix build

empty is already not a nil.

[mikio, 2011-11-15 02:22:15]

Hello golang-dev@googlegroups.com, bradfitz@golang.org (cc:
golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[mikio, 2011-11-15 02:25:39]

Well, this fix is still fragile.

http testing still barks: Unsolicited response received on idle HTTP
channel starting with ""; err=invalid argument, but I have no clue how
to fix it quickly.

On Tue, Nov 15, 2011 at 11:22 AM,  <mikioh.mikioh@gmail.com> wrote:

> Description:
> net/http: fix build
>
> empty is already not a nil.
>
> Please review this at http://codereview.appspot.com/5376099/
>
> Affected files:
>  M src/pkg/net/http/readrequest_test.go
>  M src/pkg/net/http/response_test.go

[bradfitz, 2011-11-15 02:26:13]

LGTM

I would just remove those url.Values(nil) lines, though.  They're nil by
default.


On Mon, Nov 14, 2011 at 6:22 PM, <mikioh.mikioh@gmail.com> wrote:

> Reviewers: golang-dev_googlegroups.com, bradfitz,
>
> Message:
> Hello golang-dev@googlegroups.com, bradfitz@golang.org (cc:
> golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> net/http: fix build
>
> empty is already not a nil.
>
> Please review this at
http://codereview.appspot.com/**5376099/<http://codereview.appspot.com/5376099/>
>
> Affected files:
>  M src/pkg/net/http/readrequest_**test.go
>  M src/pkg/net/http/response_**test.go
>
>
> Index: src/pkg/net/http/readrequest_**test.go
> ==============================**==============================**=======
> --- a/src/pkg/net/http/**readrequest_test.go
> +++ b/src/pkg/net/http/**readrequest_test.go
> @@ -70,7 +70,7 @@
>                        Close:         false,
>                        ContentLength: 7,
>                        Host:          "www.techcrunch.com",
> -                       Form:          url.Values{},
> +                       Form:          url.Values(nil),
>                },
>
>                "abcdef\n",
> @@ -94,10 +94,11 @@
>                        Proto:         "HTTP/1.1",
>                        ProtoMajor:    1,
>                        ProtoMinor:    1,
> +                       Header:        Header{},
>                        Close:         false,
>                        ContentLength: 0,
>                        Host:          "foo.com",
> -                       Form:          url.Values{},
> +                       Form:          url.Values(nil),
>                },
>
>                noBody,
> @@ -131,7 +132,7 @@
>                        Close:         false,
>                        ContentLength: 0,
>                        Host:          "test",
> -                       Form:          url.Values{},
> +                       Form:          url.Values(nil),
>                },
>
>                noBody,
> @@ -180,9 +181,10 @@
>                        Proto:            "HTTP/1.1",
>                        ProtoMajor:       1,
>                        ProtoMinor:       1,
> +                       Header:           Header{},
>                        ContentLength:    -1,
>                        Host:             "foo.com",
> -                       Form:             url.Values{},
> +                       Form:             url.Values(nil),
>                },
>
>                "foobar",
> Index: src/pkg/net/http/response_**test.go
> ==============================**==============================**=======
> --- a/src/pkg/net/http/response_**test.go
> +++ b/src/pkg/net/http/response_**test.go
> @@ -65,6 +65,7 @@
>                        Proto:         "HTTP/1.1",
>                        ProtoMajor:    1,
>                        ProtoMinor:    1,
> +                       Header:        Header{},
>                        Request:       dummyReq("GET"),
>                        Close:         true,
>                        ContentLength: -1,
> @@ -85,6 +86,7 @@
>                        Proto:         "HTTP/1.1",
>                        ProtoMajor:    1,
>                        ProtoMinor:    1,
> +                       Header:        Header{},
>                        Request:       dummyReq("GET"),
>                        Close:         false,
>                        ContentLength: 0,
>
>
>

[bradfitz, 2011-11-15 02:27:02]

On Mon, Nov 14, 2011 at 6:25 PM, Mikio Hara <mikioh.mikioh@gmail.com> wrote:

> Well, this fix is still fragile.
>
> http testing still barks: Unsolicited response received on idle HTTP
> channel starting with ""; err=invalid argument, but I have no clue how
> to fix it quickly.
>

That's not a failure, though.  That's just a warning, iirc, and because
Russ removed the os.EINVAL check from transport.go, I believe.

Ignore that for now.

[rsc, 2011-11-15 02:28:20]

LGTM

I'm kind of confused why I didn't hit any of these.
Please wait a few hours before submitting more of these.
If you submit them now then my dashboard filling failer
will just spend time marking them as failed instead of
working its way down to the truly buggy tests.

Thanks.

[mikio, 2011-11-15 02:35:16]

On Tue, Nov 15, 2011 at 11:28 AM, Russ Cox <rsc@golang.org> wrote:

> Please wait a few hours before submitting more of these.

ack.

[rsc, 2011-11-15 05:02:16]

It's okay to submit this now.
Thanks.

[mikio, 2011-11-15 05:05:02]

*** Submitted as http://code.google.com/p/go/source/detail?r=be4d7ed4ed68 ***

net/http: fix build

empty is already not a nil.

R=golang-dev, bradfitz, rsc
CC=golang-dev
http://codereview.appspot.com/5376099