Issue 5376098: code review 5376098: xml: fix build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5376098: code review 5376098: xml: fix build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 11 months ago by mikio

Modified:
14 years, 11 months ago

Reviewers:

CC:
golang-dev, bradfitz

Visibility:
Public.

Description

xml: fix build empty is already not a nil.

Patch Set 1 #

Patch Set 2 : diff -r a09fc0e5a98a https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r a09fc0e5a98a https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r e3a44a7d01b7 https://go.googlecode.com/hg/ #

Created: 14 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -7 lines)			Patch
	M	src/pkg/encoding/xml/xml_test.go	View	1	3 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mikio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 11 months ago (2011-11-15 01:24:02 UTC) #1

bradfitz

LGTM On Nov 14, 2011 5:24 PM, <mikioh.mikioh@gmail.com> wrote: > Reviewers: golang-dev_googlegroups.com, > > Message: ...

14 years, 11 months ago (2011-11-15 01:27:00 UTC) #2

LGTM
On Nov 14, 2011 5:24 PM, <mikioh.mikioh@gmail.com> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> xml: fix build
>
> empty is already not a nil.
>
> Please review this at
http://codereview.appspot.com/**5376098/<http://codereview.appspot.com/5376098/>
>
> Affected files:
>  M src/pkg/encoding/xml/xml_test.**go
>
>
> Index: src/pkg/encoding/xml/xml_test.**go
> ==============================**==============================**=======
> --- a/src/pkg/encoding/xml/xml_**test.go
> +++ b/src/pkg/encoding/xml/xml_**test.go
> @@ -42,17 +42,17 @@
>        CharData([]byte("World <>'\" 白鵬翔")),
>        EndElement{Name{"", "hello"}},
>        CharData([]byte("\n  ")),
> -       StartElement{Name{"", "goodbye"}, nil},
> +       StartElement{Name{"", "goodbye"}, []Attr{}},
>        EndElement{Name{"", "goodbye"}},
>        CharData([]byte("\n  ")),
>        StartElement{Name{"", "outer"}, []Attr{{Name{"foo", "attr"},
> "value"}, {Name{"xmlns", "tag"}, "ns4"}}},
>        CharData([]byte("\n    ")),
> -       StartElement{Name{"", "inner"}, nil},
> +       StartElement{Name{"", "inner"}, []Attr{}},
>        EndElement{Name{"", "inner"}},
>        CharData([]byte("\n  ")),
>        EndElement{Name{"", "outer"}},
>        CharData([]byte("\n  ")),
> -       StartElement{Name{"tag", "name"}, nil},
> +       StartElement{Name{"tag", "name"}, []Attr{}},
>        CharData([]byte("\n    ")),
>        CharData([]byte("Some text here.")),
>        CharData([]byte("\n  ")),
> @@ -76,17 +76,17 @@
>        CharData([]byte("World <>'\" 白鵬翔")),
>        EndElement{Name{"ns2", "hello"}},
>        CharData([]byte("\n  ")),
> -       StartElement{Name{"ns2", "goodbye"}, nil},
> +       StartElement{Name{"ns2", "goodbye"}, []Attr{}},
>        EndElement{Name{"ns2", "goodbye"}},
>        CharData([]byte("\n  ")),
>        StartElement{Name{"ns2", "outer"}, []Attr{{Name{"ns1", "attr"},
> "value"}, {Name{"xmlns", "tag"}, "ns4"}}},
>        CharData([]byte("\n    ")),
> -       StartElement{Name{"ns2", "inner"}, nil},
> +       StartElement{Name{"ns2", "inner"}, []Attr{}},
>        EndElement{Name{"ns2", "inner"}},
>        CharData([]byte("\n  ")),
>        EndElement{Name{"ns2", "outer"}},
>        CharData([]byte("\n  ")),
> -       StartElement{Name{"ns3", "name"}, nil},
> +       StartElement{Name{"ns3", "name"}, []Attr{}},
>        CharData([]byte("\n    ")),
>        CharData([]byte("Some text here.")),
>        CharData([]byte("\n  ")),
> @@ -104,7 +104,7 @@
>        CharData([]byte("\n")),
>        ProcInst{"xml", []byte(`version="1.0" encoding="x-testing-uppercase"
> **`)},
>        CharData([]byte("\n")),
> -       StartElement{Name{"", "tag"}, nil},
> +       StartElement{Name{"", "tag"}, []Attr{}},
>        CharData([]byte("value")),
>        EndElement{Name{"", "tag"}},
>  }
>
>
>

mikio

14 years, 11 months ago (2011-11-15 01:28:02 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=c42d15331cea ***

xml: fix build

empty is already not a nil.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5376098

Expand All Messages | Collapse All Messages