src/cmd/gc/walk.c - Issue 5376076: code review 5376076: gc: remove m[k] = x, false

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/cmd/gc/walk.c

Issue 5376076: code review 5376076: gc: remove m[k] = x, false (Closed)

Patch Set: diff -r 5a1c75805f59 https://go.googlecode.com/hg Created 13 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/cmd/gc/walk.c

===================================================================

--- a/src/cmd/gc/walk.c

+++ b/src/cmd/gc/walk.c

@@ -183,7 +183,6 @@

case OAS2DOTTYPE:

case OAS2RECV:

case OAS2FUNC:

- case OAS2MAPW:

case OAS2MAPR:

case OCLOSE:

case OCOPY:

@@ -644,17 +643,6 @@

n = mkcall1(mapfndel("mapdelete", t), t->down, init, typename(t), l, r);

goto ret;

- case OAS2MAPW:

- // map[] = a,b - mapassign2

- // a,b = m[i];

- *init = concat(*init, n->ninit);

- n->ninit = nil;

- walkexprlistsafe(n->list, init);

- l = n->list->n;

- t = l->left->type;

- n = mkcall1(mapfn("mapassign2", t), T, init, typename(t), l->left, l->right, n->rlist->n, n->rlist->next->n);

- goto ret;

case OAS2DOTTYPE:

// a,b = i.(T)

*init = concat(*init, n->ninit);

« no previous file with comments | « src/cmd/gc/typecheck.c ('k') | src/pkg/runtime/hashmap.c » ('j') | no next file with comments »