Issue 5375104: code review 5375104: gc: support for building with Plan 9 yacc

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5375104: code review 5375104: gc: support for building with Plan 9 yacc (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 11 months ago by ality

Modified:
14 years, 11 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

gc: support for building with Plan 9 yacc I've modified Plan 9's yacc to work with the grammar in go.y. These are the only changes necessary on the Go side.

Patch Set 1 #

Patch Set 2 : diff -r 9d323f7c3013 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 9d323f7c3013 https://code.google.com/p/go/ #

Created: 14 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -9 lines)			Patch
	M	src/cmd/gc/bisonerrors	View	1	2 chunks	+21 lines, -8 lines	0 comments	Download
	M	src/cmd/gc/go.h	View	1	2 chunks	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

ality

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

14 years, 11 months ago (2011-11-15 20:45:07 UTC) #1

rsc

14 years, 11 months ago (2011-11-16 21:58:06 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=7a3dc6d535b7 ***

gc: support for building with Plan 9 yacc

I've modified Plan 9's yacc to work with
the grammar in go.y.  These are the only
changes necessary on the Go side.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5375104

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages