Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(156)

Issue 5375053: Add vertical text support in Mac port (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by caryclark1
Modified:
10 years ago
Reviewers:
reed1
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Draw text vertically if the flag in the scaler is set. The general strategy is to get the vertical advance, and correct the glyph's left and top by the font's vertical offsets. Add specialization to work around a Snow Leopard in CTFontGetVerticalTranslationsForGlyphs. The font size can be retrieved more reliably from the scaler than from the CTFont -- use fTextSize instead of CTFontGetSize. Use the CTFontGetUnitsPerEm instead of reading the font data directly. Add a utility to flip the matrix to account for different Y axis directions. Set the newly created CTFont to have a vertical attribute dictionary entry as appropriate

Patch Set 1 #

Total comments: 1

Patch Set 2 : add missing int-to-scalar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -33 lines) Patch
M src/ports/SkFontHost_mac_coretext.cpp View 1 11 chunks +103 lines, -33 lines 0 comments Download

Messages

Total messages: 2
caryclark1
10 years ago (2011-11-10 17:20:51 UTC) #1
reed1
10 years ago (2011-11-10 18:17:20 UTC) #2
nit about inttoscalar(90)

lgtm

http://codereview.appspot.com/5375053/diff/1/src/ports/SkFontHost_mac_coretex...
File src/ports/SkFontHost_mac_coretext.cpp (right):

http://codereview.appspot.com/5375053/diff/1/src/ports/SkFontHost_mac_coretex...
src/ports/SkFontHost_mac_coretext.cpp:669: } else {
SkIntToScalar(90)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b