Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(109)

Issue 53740045: Don't start a new ssh-agent unless needed.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by bac
Modified:
11 years, 10 months ago
Reviewers:
mp+204348
Visibility:
Public.

Description

Don't start a new ssh-agent unless needed. If quickstart creates its own ssh-agent it renders a previously running one unusable. Keys that were already added must be added again. And, when the quikstart process dies, the environment variables it had set up as required by ssh-agent are not available to the parent shell, so that agent effectively becomes a zombie. Instead, check for the existence of a running agent before spinning up a new one. If none exists, then launch a new one and then check again to ensure it is running. https://code.launchpad.net/~bac/juju-quickstart/ssh-agent/+merge/204348 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Don't start a new ssh-agent unless needed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -30 lines) Patch
M Makefile View 2 chunks +4 lines, -0 lines 0 comments Download
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M quickstart/app.py View 1 chunk +7 lines, -0 lines 0 comments Download
M quickstart/tests/test_app.py View 1 11 chunks +53 lines, -30 lines 0 comments Download

Messages

Total messages: 2
bac
Please take a look.
11 years, 10 months ago (2014-01-31 21:07:31 UTC) #1
bac
11 years, 10 months ago (2014-01-31 21:40:41 UTC) #2
Please take a look.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b