Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(173)

Issue 5373099: Upgrade to Eclipse 3.7 & fix some pom.xml warnings (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years ago by yanivi
Modified:
14 years ago
Reviewers:
rmistry
Base URL:
https://code.google.com/p/google-http-java-client/
Visibility:
Public.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -59 lines) Patch
M google-http-client-extensions-android2/.classpath View 1 chunk +1 line, -1 line 0 comments Download
M google-http-client-extensions-android2/.project View 1 chunk +2 lines, -2 lines 0 comments Download
M google-http-client-extensions-android2/pom.xml View 1 chunk +29 lines, -0 lines 0 comments Download
M google-http-client-extensions-android3/.classpath View 1 chunk +6 lines, -4 lines 0 comments Download
M google-http-client-extensions-android3/.project View 1 chunk +2 lines, -2 lines 0 comments Download
M google-http-client-extensions-android3/pom.xml View 1 chunk +29 lines, -0 lines 0 comments Download
M google-http-client-extensions/.classpath View 1 chunk +1 line, -1 line 0 comments Download
M google-http-client-extensions/.project View 1 chunk +20 lines, -20 lines 0 comments Download
M google-http-client-extensions/pom.xml View 2 chunks +29 lines, -1 line 0 comments Download
M google-http-client/.classpath View 1 chunk +4 lines, -3 lines 0 comments Download
M google-http-client/.project View 1 chunk +20 lines, -20 lines 0 comments Download
M google-http-client/pom.xml View 1 chunk +61 lines, -0 lines 2 comments Download
M pom.xml View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4
yanivi
14 years ago (2011-11-15 14:07:00 UTC) #1
yanivi
Ping (in case you missed it)
14 years ago (2011-11-15 16:27:01 UTC) #2
rmistry
LGTM http://codereview.appspot.com/5373099/diff/1/google-http-client/pom.xml File google-http-client/pom.xml (left): http://codereview.appspot.com/5373099/diff/1/google-http-client/pom.xml#oldcode5 google-http-client/pom.xml:5: <groupId>com.google.http-client</groupId> groupId here is not needed?
14 years ago (2011-11-15 17:10:07 UTC) #3
yanivi
14 years ago (2011-11-15 17:49:03 UTC) #4
Submitting now...

http://codereview.appspot.com/5373099/diff/1/google-http-client/pom.xml
File google-http-client/pom.xml (left):

http://codereview.appspot.com/5373099/diff/1/google-http-client/pom.xml#oldcode5
google-http-client/pom.xml:5: <groupId>com.google.http-client</groupId>
On 2011/11/15 17:10:07, rmistry wrote:
> groupId here is not needed?

It is needed, because here we are specifying the groupId of the parent.  What is
not needed is the groupId of the child since it is redundant from the groupId of
the parent.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b