Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1292)

Issue 5373079: code review 5373079: gc: remove func, map compare (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by rsc
Modified:
13 years, 4 months ago
Reviewers:
CC:
ken2, ken3, golang-dev
Visibility:
Public.

Description

gc: remove func, map compare

Patch Set 1 #

Patch Set 2 : diff -r daa23bc3b7c5 https://go.googlecode.com/hg #

Patch Set 3 : diff -r daa23bc3b7c5 https://go.googlecode.com/hg #

Patch Set 4 : diff -r 8ed90e9d30ab https://go.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+301 lines, -125 lines) Patch
M src/cmd/gc/align.c View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/cmd/gc/subr.c View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/cmd/gc/swt.c View 1 4 chunks +14 lines, -0 lines 0 comments Download
M src/cmd/gc/typecheck.c View 1 2 chunks +11 lines, -2 lines 0 comments Download
M test/closure.go View 1 2 chunks +0 lines, -5 lines 0 comments Download
M test/cmp6.go View 1 2 3 3 chunks +18 lines, -10 lines 0 comments Download
M test/fixedbugs/bug285.go View 1 1 chunk +0 lines, -14 lines 0 comments Download
M test/map1.go View 1 2 3 2 chunks +15 lines, -15 lines 0 comments Download
M test/switch.go View 1 2 3 2 chunks +212 lines, -69 lines 0 comments Download
M test/switch3.go View 1 2 3 2 chunks +24 lines, -4 lines 0 comments Download
M test/typeswitch.go View 1 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg
13 years, 4 months ago (2011-11-12 05:25:36 UTC) #1
ken3
lgtm
13 years, 4 months ago (2011-11-12 12:37:56 UTC) #2
rsc
13 years, 4 months ago (2011-11-14 03:58:08 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=c987cc71cf15 ***

gc: remove func, map compare

R=ken, ken
CC=golang-dev
http://codereview.appspot.com/5373079
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b