Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(214)

Issue 53730045: Set the executable bit for checked-in binaries. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by chrisha
Modified:
10 years, 2 months ago
CC:
sawbuck-changes_googlegroups.com, pkasting
Base URL:
http://sawbuck.googlecode.com/svn/trunk
Visibility:
Public.

Description

Set the executable bit for checked-in binaries. This also updates release_binaries.py to automate this step, preventing regressions on future binary releases. This is required so as to not to break Cygwin support in Chromium builds. BUG= TBR=siggi@chromium.org Committed: https://code.google.com/p/sawbuck/source/detail?r=2000

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+-4 lines, --31 lines) Patch
A syzygy/binaries/benchmark.bat View 0 chunks +-1 lines, --1 lines 0 comments Download
A syzygy/binaries/exe/agent_logger.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
A syzygy/binaries/exe/call_trace_control.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
A syzygy/binaries/exe/call_trace_service.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
A syzygy/binaries/exe/decompose.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
A syzygy/binaries/exe/decompose_image_to_text.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
A syzygy/binaries/exe/dump_trace.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
A syzygy/binaries/exe/experimental/code_tally.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
A syzygy/binaries/exe/experimental/compare.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
A syzygy/binaries/exe/experimental/convert_code_tally.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A syzygy/binaries/exe/experimental/pdb_dumper.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
A syzygy/binaries/exe/experimental/timed_decomposer.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
A syzygy/binaries/exe/genfilter.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
A syzygy/binaries/exe/grinder.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
A syzygy/binaries/exe/instrument.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
A syzygy/binaries/exe/pdbfind.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
A syzygy/binaries/exe/pehacker.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
A syzygy/binaries/exe/relink.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
A syzygy/binaries/exe/reorder.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
A syzygy/binaries/exe/run_in_snapshot.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
A syzygy/binaries/exe/run_in_snapshot_x64.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
A syzygy/binaries/exe/run_in_snapshot_xp.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
A syzygy/binaries/exe/sampler.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
A syzygy/binaries/exe/simulate.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
A syzygy/binaries/exe/swapimport.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
A syzygy/binaries/exe/wsdump.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
A syzygy/binaries/exe/zap_timestamp.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
A syzygy/binaries/grinder.bat View 0 chunks +-1 lines, --1 lines 0 comments Download
A syzygy/binaries/instrument.bat View 0 chunks +-1 lines, --1 lines 0 comments Download
A syzygy/binaries/optimize.bat View 0 chunks +-1 lines, --1 lines 0 comments Download
A syzygy/binaries/profile.bat View 0 chunks +-1 lines, --1 lines 0 comments Download
M syzygy/build/release_binaries.py View 3 chunks +27 lines, -0 lines 1 comment Download

Messages

Total messages: 4
chrisha
Committing this TBR to fix the Cygwin build. Siggi, can you review for the Python ...
10 years, 2 months ago (2014-01-18 21:33:38 UTC) #1
chrisha
Committed patchset #1 manually as r2000.
10 years, 2 months ago (2014-01-18 22:12:54 UTC) #2
Sébastien Marchand
lgtm
10 years, 2 months ago (2014-01-20 15:31:24 UTC) #3
Siggi
10 years, 2 months ago (2014-01-20 22:08:29 UTC) #4
Message was sent while issue was closed.
lgtm with a nit.

https://codereview.appspot.com/53730045/diff/1/syzygy/build/release_binaries.py
File syzygy/build/release_binaries.py (right):

https://codereview.appspot.com/53730045/diff/1/syzygy/build/release_binaries....
syzygy/build/release_binaries.py:189: while dirs:
nit: The python idiom is 

for d in dirs:
 ...

Also there's an os.path.walk that'll recursively iterate/enumerate a directory.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b