Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(24)

Issue 5372107: code review 5372107: sql: document that for drivers, io.EOF means no more rows (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by bradfitz
Modified:
13 years, 4 months ago
Reviewers:
CC:
golang-dev, gri
Visibility:
Public.

Description

sql: document that for drivers, io.EOF means no more rows This was used in the sql package + tests, but never documented.

Patch Set 1 #

Patch Set 2 : diff -r d89a2c57c454 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r d89a2c57c454 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r d89a2c57c454 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/pkg/exp/sql/driver/driver.go View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3
bradfitz
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 4 months ago (2011-11-15 22:23:40 UTC) #1
gri
LGTM On Tue, Nov 15, 2011 at 2:23 PM, <bradfitz@golang.org> wrote: > Reviewers: golang-dev_googlegroups.com, > ...
13 years, 4 months ago (2011-11-15 22:28:51 UTC) #2
bradfitz
13 years, 4 months ago (2011-11-15 22:29:52 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=69a3bac021b1 ***

sql: document that for drivers, io.EOF means no more rows

This was used in the sql package + tests, but never
documented.

R=golang-dev, gri
CC=golang-dev
http://codereview.appspot.com/5372107
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b