Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(34)

Issue 5372083: code review 5372083: exp/ssh: ensure initial window advertisement is not lost (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by dave
Modified:
13 years, 4 months ago
Reviewers:
CC:
agl1, rsc, cw, golang-dev
Visibility:
Public.

Description

exp/ssh: ensure initial window advertisement is not lost Some remote servers send a 0 window size in the channel open confirm msg, others send a non zero window size. Make sure this initial advertisement is not lost.

Patch Set 1 #

Patch Set 2 : diff -r c9aed8a4d37b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r c9aed8a4d37b https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/pkg/exp/ssh/client.go View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2
dave_cheney.net
Hello agl@golang.org, rsc@golang.org, cw@f00f.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 4 months ago (2011-11-13 06:49:12 UTC) #1
agl1
13 years, 4 months ago (2011-11-13 17:13:56 UTC) #2
*** Submitted as http://code.google.com/p/go/source/detail?r=01baaa1a6b5a ***

exp/ssh: ensure initial window advertisement is not lost

Some remote servers send a 0 window size in the channel
open confirm msg, others send a non zero window size. Make
sure this initial advertisement is not lost.

R=agl, rsc, cw
CC=golang-dev
http://codereview.appspot.com/5372083

Committer: Adam Langley <agl@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b