src/pkg/os/user/lookup_unix.go - Issue 5372080: code review 5372080: syscall: use error

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/pkg/os/user/lookup_unix.go

Issue 5372080: code review 5372080: syscall: use error (Closed)

Patch Set: diff -r 25e37de63f5d https://go.googlecode.com/hg/ Created 13 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/pkg/os/user/lookup_unix.go

===================================================================

--- a/src/pkg/os/user/lookup_unix.go

+++ b/src/pkg/os/user/lookup_unix.go

@@ -8,9 +8,9 @@

import (

"fmt"

- "os"

"runtime"

"strings"

+ "syscall"

"unsafe"

)

@@ -71,7 +71,7 @@

C.size_t(bufSize),

&result)

if rv != 0 {

- return nil, fmt.Errorf("user: lookup username %s: %s", username, os.Errno(rv))

+ return nil, fmt.Errorf("user: lookup username %s: %s", username, syscall.Errno(rv))

}

if result == nil {

return nil, UnknownUserError(username)

@@ -86,7 +86,7 @@

C.size_t(bufSize),

&result)

if rv != 0 {

- return nil, fmt.Errorf("user: lookup userid %d: %s", uid, os.Errno(rv))

+ return nil, fmt.Errorf("user: lookup userid %d: %s", uid, syscall.Errno(rv))

}

if result == nil {

return nil, UnknownUserIdError(uid)

« no previous file with comments | « src/pkg/os/time.go ('k') | src/pkg/syscall/bpf_bsd.go » ('j') | no next file with comments »