code review 5371092: {syscall,os,time}.go: tentative fixes for port to Plan 9

{syscall,os,time}.go: tentative fixes for port to Plan 9

src/pkg/time/sys_plan9.go: remove leftover, unused imports.

Others: Corrected various uses of "error" and "Errno".

[lucio, 2011-11-14 20:47:24]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com,
rsc@golang.org),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-11-14 21:10:35]

looks good except for UnixSignal

http://codereview.appspot.com/5371092/diff/1002/src/pkg/os/exec_plan9.go
File src/pkg/os/exec_plan9.go (right):

http://codereview.appspot.com/5371092/diff/1002/src/pkg/os/exec_plan9.go#newc...
src/pkg/os/exec_plan9.go:13: type UnixSignal int32
This seems unrelated.
Please remove from this CL.

[lucio, 2011-11-15 03:08:04]

No idea where that came from, I'll sort it out.

Lucio.


On 11/14/11, rsc@golang.org <rsc@golang.org> wrote:
> looks good except for UnixSignal
>
>
>
> http://codereview.appspot.com/5371092/diff/1002/src/pkg/os/exec_plan9.go
> File src/pkg/os/exec_plan9.go (right):
>
>
http://codereview.appspot.com/5371092/diff/1002/src/pkg/os/exec_plan9.go#newc...
> src/pkg/os/exec_plan9.go:13: type UnixSignal int32
> This seems unrelated.
> Please remove from this CL.
>
> http://codereview.appspot.com/5371092/
>

[lucio, 2011-11-15 03:36:08]

Is there a reason for:

$ hg sync
abort: HTTP Error 500: Internal Server Error

?


On 11/15/11, Lucio De Re <lucio.dere@gmail.com> wrote:
> No idea where that came from, I'll sort it out.
>
> Lucio.
>
>
> On 11/14/11, rsc@golang.org <rsc@golang.org> wrote:
>> looks good except for UnixSignal
>>
>>
>>
>> http://codereview.appspot.com/5371092/diff/1002/src/pkg/os/exec_plan9.go
>> File src/pkg/os/exec_plan9.go (right):
>>
>>
http://codereview.appspot.com/5371092/diff/1002/src/pkg/os/exec_plan9.go#newc...
>> src/pkg/os/exec_plan9.go:13: type UnixSignal int32
>> This seems unrelated.
>> Please remove from this CL.
>>
>> http://codereview.appspot.com/5371092/
>>
>

[bradfitz, 2011-11-15 03:38:27]

Probably, but likely not a good one, and not one that we can find easily.

Just retry.


On Mon, Nov 14, 2011 at 7:36 PM, Lucio De Re <lucio.dere@gmail.com> wrote:

> Is there a reason for:
>
> $ hg sync
> abort: HTTP Error 500: Internal Server Error
>
> ?
>
>
> On 11/15/11, Lucio De Re <lucio.dere@gmail.com> wrote:
> > No idea where that came from, I'll sort it out.
> >
> > Lucio.
> >
> >
> > On 11/14/11, rsc@golang.org <rsc@golang.org> wrote:
> >> looks good except for UnixSignal
> >>
> >>
> >>
> >>
> http://codereview.appspot.com/5371092/diff/1002/src/pkg/os/exec_plan9.go
> >> File src/pkg/os/exec_plan9.go (right):
> >>
> >>
>
http://codereview.appspot.com/5371092/diff/1002/src/pkg/os/exec_plan9.go#newc...
> >> src/pkg/os/exec_plan9.go:13: type UnixSignal int32
> >> This seems unrelated.
> >> Please remove from this CL.
> >>
> >> http://codereview.appspot.com/5371092/
> >>
> >
>

[lucio, 2011-11-15 03:49:55]

Thanks, the problem seems to have been cleared.

Lucio.


On 11/15/11, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> Probably, but likely not a good one, and not one that we can find easily.
>
> Just retry.
>
>
> On Mon, Nov 14, 2011 at 7:36 PM, Lucio De Re <lucio.dere@gmail.com> wrote:
>
>> Is there a reason for:
>>
>> $ hg sync
>> abort: HTTP Error 500: Internal Server Error
>>
>> ?
>>
>>
>> On 11/15/11, Lucio De Re <lucio.dere@gmail.com> wrote:
>> > No idea where that came from, I'll sort it out.
>> >
>> > Lucio.
>> >
>> >
>> > On 11/14/11, rsc@golang.org <rsc@golang.org> wrote:
>> >> looks good except for UnixSignal
>> >>
>> >>
>> >>
>> >>
>> http://codereview.appspot.com/5371092/diff/1002/src/pkg/os/exec_plan9.go
>> >> File src/pkg/os/exec_plan9.go (right):
>> >>
>> >>
>>
http://codereview.appspot.com/5371092/diff/1002/src/pkg/os/exec_plan9.go#newc...
>> >> src/pkg/os/exec_plan9.go:13: type UnixSignal int32
>> >> This seems unrelated.
>> >> Please remove from this CL.
>> >>
>> >> http://codereview.appspot.com/5371092/
>> >>
>> >
>>
>

[lucio, 2011-11-15 04:30:28]

Hello rsc@golang.org, bradfitz@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2011-11-16 22:37:56]

*** Submitted as http://code.google.com/p/go/source/detail?r=05e3714c033a ***

syscall, os, time: fix Plan 9 build

R=rsc, bradfitz
CC=golang-dev
http://codereview.appspot.com/5371092

Committer: Russ Cox <rsc@golang.org>

[lucio, 2011-11-18 04:26:17]

I still have UnixSignal lurking in my CodeReview folder, any idea
where it belongs?  I have no recollection as to where it came from.

Lucio.

On 11/14/11, rsc@golang.org <rsc@golang.org> wrote:
> looks good except for UnixSignal
>
>
>
> http://codereview.appspot.com/5371092/diff/1002/src/pkg/os/exec_plan9.go
> File src/pkg/os/exec_plan9.go (right):
>
>
http://codereview.appspot.com/5371092/diff/1002/src/pkg/os/exec_plan9.go#newc...
> src/pkg/os/exec_plan9.go:13: type UnixSignal int32
> This seems unrelated.
> Please remove from this CL.
>
> http://codereview.appspot.com/5371092/
>

[rsc, 2011-11-18 23:34:40]

On Thu, Nov 17, 2011 at 23:26, Lucio De Re <lucio.dere@gmail.com> wrote:
> I still have UnixSignal lurking in my CodeReview folder, any idea
> where it belongs?  I have no recollection as to where it came from.

I'd start by deleting that change and see what breaks.

[lucio, 2011-11-19 13:52:57]

Found it: os.UnixSignal() is invoked in pkg/os/signal/signal.go.  It
ought to be part of someone else's outstanding CL, will the culprit
please stand up?

Lucio.

On 11/19/11, Russ Cox <rsc@golang.org> wrote:
> On Thu, Nov 17, 2011 at 23:26, Lucio De Re <lucio.dere@gmail.com> wrote:
>> I still have UnixSignal lurking in my CodeReview folder, any idea
>> where it belongs?  I have no recollection as to where it came from.
>
> I'd start by deleting that change and see what breaks.
>

[rsc, 2011-11-21 14:52:37]

On Sat, Nov 19, 2011 at 08:52, Lucio De Re <lucio.dere@gmail.com> wrote:
> Found it: os.UnixSignal() is invoked in pkg/os/signal/signal.go.  It
> ought to be part of someone else's outstanding CL, will the culprit
> please stand up?

You should not bother trying to compile os/signal on Plan 9 right now.
The implementation there is Unix-specific and would need to be
rewritten for Plan 9.  The use of UnixSignal is just the tip of the
iceberg.

Russ