Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1294)

Issue 5371074: code review 5371074: various: avoid func compare (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by rsc
Modified:
13 years, 4 months ago
Reviewers:
CC:
gri, r, bradfitz, golang-dev
Visibility:
Public.

Description

various: avoid func compare

Patch Set 1 #

Patch Set 2 : diff -r daa23bc3b7c5 https://go.googlecode.com/hg #

Patch Set 3 : diff -r daa23bc3b7c5 https://go.googlecode.com/hg #

Total comments: 8

Patch Set 4 : diff -r daa23bc3b7c5 https://go.googlecode.com/hg #

Patch Set 5 : diff -r daa23bc3b7c5 https://go.googlecode.com/hg #

Patch Set 6 : diff -r b5c1528ecf37 https://go.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -107 lines) Patch
M src/cmd/gofix/main_test.go View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M src/cmd/gofix/typecheck.go View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M src/pkg/bytes/bytes_test.go View 1 1 chunk +32 lines, -31 lines 0 comments Download
M src/pkg/compress/lzw/writer.go View 1 2 3 4 5 3 chunks +5 lines, -3 lines 0 comments Download
M src/pkg/encoding/json/decode.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/encoding/json/scanner.go View 1 2 3 4 7 chunks +15 lines, -4 lines 0 comments Download
M src/pkg/go/ast/filter.go View 1 8 chunks +41 lines, -29 lines 0 comments Download
M src/pkg/net/ipsock.go View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/strings/strings_test.go View 1 1 chunk +32 lines, -31 lines 0 comments Download

Messages

Total messages: 5
rsc
Hello gri, r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg
13 years, 4 months ago (2011-11-12 05:25:20 UTC) #1
bradfitz
http://codereview.appspot.com/5371074/diff/4008/src/cmd/gofix/typecheck.go File src/cmd/gofix/typecheck.go (right): http://codereview.appspot.com/5371074/diff/4008/src/cmd/gofix/typecheck.go#newcode189 src/cmd/gofix/typecheck.go:189: if !copied { where does copied ever get set ...
13 years, 4 months ago (2011-11-12 05:42:40 UTC) #2
r
LGTM kind of a shame http://codereview.appspot.com/5371074/diff/4008/src/cmd/gofix/typecheck.go File src/cmd/gofix/typecheck.go (right): http://codereview.appspot.com/5371074/diff/4008/src/cmd/gofix/typecheck.go#newcode194 src/cmd/gofix/typecheck.go:194: } copied = true ...
13 years, 4 months ago (2011-11-12 06:25:25 UTC) #3
rsc
All comments applied, thanks.
13 years, 4 months ago (2011-11-14 03:50:32 UTC) #4
rsc
13 years, 4 months ago (2011-11-14 03:57:19 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=401c905a115f ***

various: avoid func compare

R=gri, r, bradfitz
CC=golang-dev
http://codereview.appspot.com/5371074
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b