Issue 5370101: code review 5370101: misc/emacs: add delete builtin

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5370101: code review 5370101: misc/emacs: add delete builtin

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by bpowers

Modified:
13 years, 4 months ago

Reviewers:
gri

CC:
golang-dev, mpimenov, gri

Visibility:
Public.

Patch Set 2 : diff -r be4d7ed4ed68 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r be4d7ed4ed68 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r be4d7ed4ed68 https://go.googlecode.com/hg/ #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	misc/emacs/go-mode.el	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bpowers

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 4 months ago (2011-11-15 15:12:23 UTC) #1

mpimenov

http://codereview.appspot.com/5370101/diff/1002/misc/emacs/go-mode.el File misc/emacs/go-mode.el (right): http://codereview.appspot.com/5370101/diff/1002/misc/emacs/go-mode.el#newcode72 misc/emacs/go-mode.el:72: (let ((builtins '("append" "cap" "close" "complex" "copy" "imag" "len" ...

13 years, 4 months ago (2011-11-15 16:13:57 UTC) #2

bpowers

Hello golang-dev@googlegroups.com, mpimenov@google.com (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 4 months ago (2011-11-15 16:20:51 UTC) #3

gri

13 years, 4 months ago (2011-11-15 18:22:39 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=a411cfe2148e ***

misc/emacs: add delete builtin

R=golang-dev, mpimenov, gri
CC=golang-dev
http://codereview.appspot.com/5370101

Committer: Robert Griesemer <gri@golang.org>

Expand All Messages | Collapse All Messages