Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(288)

Issue 5369090: code review 5369090: spec: disallow general func, map comparisons (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by rsc
Modified:
13 years, 4 months ago
Reviewers:
CC:
golang-dev, gri, r, r2
Visibility:
Public.

Description

spec: disallow general func, map comparisons

Patch Set 1 #

Patch Set 2 : diff -r cfd7b6784171 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r cfd7b6784171 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r cfd7b6784171 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 5 : diff -r 401c905a115f https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M doc/go_spec.html View 1 2 3 4 2 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 7
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 4 months ago (2011-11-12 06:47:06 UTC) #1
gri
LGTM I don't recall anymore why we decided to remove map comparison m1 == m2.
13 years, 4 months ago (2011-11-12 06:52:34 UTC) #2
r
LGTM http://codereview.appspot.com/5369090/diff/5001/doc/go_spec.html File doc/go_spec.html (right): http://codereview.appspot.com/5369090/diff/5001/doc/go_spec.html#newcode2969 doc/go_spec.html:2969: A slice, map, or function value may only ...
13 years, 4 months ago (2011-11-12 16:07:45 UTC) #3
r2
On Nov 11, 2011, at 10:52 PM, gri@golang.org wrote: > LGTM > > I don't ...
13 years, 4 months ago (2011-11-12 16:09:39 UTC) #4
rsc
On Sat, Nov 12, 2011 at 01:52, <gri@golang.org> wrote: > I don't recall anymore why ...
13 years, 4 months ago (2011-11-12 16:33:18 UTC) #5
r
that too. -rob
13 years, 4 months ago (2011-11-12 16:56:37 UTC) #6
rsc
13 years, 4 months ago (2011-11-14 03:57:45 UTC) #7
*** Submitted as http://code.google.com/p/go/source/detail?r=8ed90e9d30ab ***

spec: disallow general func, map comparisons

R=golang-dev, gri, r, r
CC=golang-dev
http://codereview.appspot.com/5369090
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b