Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(49)

Issue 5364048: Adds some info about pure properties to the CG. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years ago by MikeSol
Modified:
7 years, 12 months ago
Reviewers:
pkx166h, Graham Percival, dak, mike, Keith
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Adds some info about pure properties to the CG.

Patch Set 1 #

Patch Set 2 : Compiles in make all #

Total comments: 15

Patch Set 3 : Incorporates suggestions from Keith and Joe. #

Total comments: 1

Patch Set 4 : Adds @end itemize #

Unified diffs Side-by-side diffs Delta from patch set Stats (+294 lines, -1 line) Patch
M Documentation/contributor/programming-work.itexi View 1 2 3 2 chunks +294 lines, -1 line 0 comments Download

Messages

Total messages: 11
pkx166h
passes make and a full make doc. James
8 years ago (2011-11-11 19:17:35 UTC) #1
Graham Percival
sure, looks fine. It's more important to get stuff into the CG than it is ...
8 years ago (2011-11-15 22:10:23 UTC) #2
joeneeman
http://codereview.appspot.com/5364048/diff/4001/Documentation/contributor/programming-work.itexi File Documentation/contributor/programming-work.itexi (right): http://codereview.appspot.com/5364048/diff/4001/Documentation/contributor/programming-work.itexi#newcode1836 Documentation/contributor/programming-work.itexi:1836: LilyPond). Purity is not only about returning predictable values. ...
8 years ago (2011-11-16 01:19:06 UTC) #3
mike_apollinemike.com
On Nov 16, 2011, at 2:19 AM, joeneeman@gmail.com wrote: > > http://codereview.appspot.com/5364048/diff/4001/Documentation/contributor/programming-work.itexi > File Documentation/contributor/programming-work.itexi ...
8 years ago (2011-11-18 16:37:33 UTC) #4
joeneeman
Bah, I just wrote out a nice reply on the codereview site and it got ...
8 years ago (2011-11-20 23:19:04 UTC) #5
mike_apollinemike.com
On Sun, 20 Nov 2011 15:19:03 -0800, Joe Neeman wrote: > Bah, I just wrote ...
8 years ago (2011-11-21 07:44:36 UTC) #6
joeneeman
On 2011/11/21 07:44:36, mike_apollinemike.com wrote: > I'm going to leave it this way if that's ...
8 years ago (2011-11-21 07:55:20 UTC) #7
Keith
http://codereview.appspot.com/5364048/diff/4001/Documentation/contributor/programming-work.itexi File Documentation/contributor/programming-work.itexi (right): http://codereview.appspot.com/5364048/diff/4001/Documentation/contributor/programming-work.itexi#newcode1832 Documentation/contributor/programming-work.itexi:1832: a @emph{prima face}. If you write a pure-function, you ...
8 years ago (2011-11-21 08:02:00 UTC) #8
dak
http://codereview.appspot.com/5364048/diff/4001/Documentation/contributor/programming-work.itexi File Documentation/contributor/programming-work.itexi (right): http://codereview.appspot.com/5364048/diff/4001/Documentation/contributor/programming-work.itexi#newcode1832 Documentation/contributor/programming-work.itexi:1832: a @emph{prima face}. If you write a pure-function, you ...
8 years ago (2011-11-21 08:06:39 UTC) #9
pkx166h
http://codereview.appspot.com/5364048/diff/11002/Documentation/contributor/programming-work.itexi File Documentation/contributor/programming-work.itexi (right): http://codereview.appspot.com/5364048/diff/11002/Documentation/contributor/programming-work.itexi#newcode1809 Documentation/contributor/programming-work.itexi:1809: @item @code{suicide} Mike you need an @end itemize Here ...
8 years ago (2011-11-21 17:31:07 UTC) #10
pkx166h
8 years ago (2011-11-22 10:52:32 UTC) #11
passes make - haven't done a full make doc yet though.

James
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b