code review 5348052: runtime, syscall: convert from godefs to cgo

runtime, syscall: convert from godefs to cgo

[rsc, 2011-11-09 05:25:29]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-11-09 05:26:46]

(Note that this is not making runtime and syscall
depend on cgo in the same way that net does.
It is just using cgo to generate some files offline.)

[mikio, 2011-11-09 07:14:54]

http://codereview.appspot.com/5348052/diff/5031/src/pkg/syscall/types_freebsd.go
File src/pkg/syscall/types_freebsd.go (right):

http://codereview.appspot.com/5348052/diff/5031/src/pkg/syscall/types_freebsd...
src/pkg/syscall/types_freebsd.go:13: 
one more.
// +godefs map struct_fsid [8]byte /* __fsid_t */

http://codereview.appspot.com/5348052/diff/5031/src/pkg/syscall/types_openbsd.go
File src/pkg/syscall/types_openbsd.go (right):

http://codereview.appspot.com/5348052/diff/5031/src/pkg/syscall/types_openbsd...
src/pkg/syscall/types_openbsd.go:13: 
two more.
// +godefs map struct___1 [8]byte /* __fsid_t */
// +godefs map struct_mclpool [12]byte /* mclpool */

[rsc, 2011-11-09 20:39:32]

On Nov 9, 2011 at 02:14, mikioh.mikioh@gmail.com wrote:
>
http://codereview.appspot.com/5348052/diff/5031/src/pkg/syscall/types_freebsd...
> src/pkg/syscall/types_freebsd.go:13:
> one more.
> // +godefs map struct_fsid [8]byte /* __fsid_t */
> 
>
http://codereview.appspot.com/5348052/diff/5031/src/pkg/syscall/types_openbsd.go
> File src/pkg/syscall/types_openbsd.go (right):
> 
>
http://codereview.appspot.com/5348052/diff/5031/src/pkg/syscall/types_openbsd...
> src/pkg/syscall/types_openbsd.go:13:
> two more.
> // +godefs map struct___1 [8]byte /* __fsid_t */
> // +godefs map struct_mclpool [12]byte /* mclpool */

Thanks for testing this on those systems.

I've been trying to avoid these if possible, because
having to specify the size - which is taken on faith
by cgo - is somewhat fragile.  I now see that there's
one left over in types_linux.go that I need to remove.

For both types_freebsd.go and types_openbsd.go, 
does it work to define the Fsid type like types_darwin.go does?

For types_openbsd.go's mclpool, does it work to define

    type Mclpool C.struct_mclpool

or is there something more complicated involved?

Thanks.
Russ

[r, 2011-11-09 22:25:56]

LGTM once enough systems are happy

[mikio, 2011-11-10 02:23:55]

On 2011/11/09 20:39:32, rsc wrote:

> For both types_freebsd.go and types_openbsd.go, 
> does it work to define the Fsid type like types_darwin.go does?
> 
> For types_openbsd.go's mclpool, does it work to define
> 
>     type Mclpool C.struct_mclpool

Yup, that makes sense.

[mikio, 2011-11-10 02:27:22]

LGTM

http://codereview.appspot.com/5348052/diff/5031/src/pkg/syscall/types_freebsd.go
File src/pkg/syscall/types_freebsd.go (right):

http://codereview.appspot.com/5348052/diff/5031/src/pkg/syscall/types_freebsd...
src/pkg/syscall/types_freebsd.go:125: 
type Fsid C.struct_fsid

http://codereview.appspot.com/5348052/diff/5031/src/pkg/syscall/types_openbsd.go
File src/pkg/syscall/types_openbsd.go (right):

http://codereview.appspot.com/5348052/diff/5031/src/pkg/syscall/types_openbsd...
src/pkg/syscall/types_openbsd.go:122: 
type Fsid C.fsid_t

http://codereview.appspot.com/5348052/diff/5031/src/pkg/syscall/types_openbsd...
src/pkg/syscall/types_openbsd.go:198: 
type Mclpool C.struct_mclpool

[rsc, 2011-11-11 00:08:32]

*** Submitted as http://code.google.com/p/go/source/detail?r=b5b8898c7002 ***

runtime, syscall: convert from godefs to cgo

R=golang-dev, mikioh.mikioh, r
CC=golang-dev
http://codereview.appspot.com/5348052

[rsc, 2011-11-11 00:13:29]

I submitted this.

Mikioh, would you be willing to rerun mkall.sh for
FreeBSD and OpenBSD and send a CL updating
the ztypes files?

Thanks.
Russ

[mikio, 2011-11-11 10:22:31]

On Fri, Nov 11, 2011 at 9:13 AM, Russ Cox <rsc@golang.org> wrote:

> Mikioh, would you be willing to rerun mkall.sh for
> FreeBSD and OpenBSD and send a CL updating
> the ztypes files?

Sure, will do.