Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(163)

Issue 5348047: client_secrets.json support (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 6 months ago by yanivi
Modified:
13 years, 6 months ago
Reviewers:
rmistry
Base URL:
https://code.google.com/p/google-api-java-client.samples/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : remove -SNAPSHOT from base libraries #

Patch Set 3 : more small fixes #

Total comments: 2

Patch Set 4 : update instructions.html #

Unified diffs Side-by-side diffs Delta from patch set Stats (+366 lines, -320 lines) Patch
M books-cmdline-sample/pom.xml View 1 1 chunk +1 line, -1 line 0 comments Download
M books-cmdline-sample/src/main/java/com/google/api/services/samples/books/cmdline/BooksSample.java View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M calendar-android-sample/.classpath View 1 1 chunk +10 lines, -10 lines 0 comments Download
M calendar-android-sample/pom.xml View 1 1 chunk +3 lines, -3 lines 0 comments Download
M calendar-cmdline-sample/.project View 1 chunk +5 lines, -0 lines 0 comments Download
M calendar-cmdline-sample/instructions.html View 1 2 3 1 chunk +5 lines, -3 lines 0 comments Download
M calendar-cmdline-sample/pom.xml View 1 chunk +2 lines, -2 lines 0 comments Download
M calendar-cmdline-sample/src/main/java/com/google/api/services/samples/calendar/cmdline/CalendarSample.java View 4 chunks +4 lines, -11 lines 0 comments Download
M discovery-cmdline-sample/.project View 1 chunk +5 lines, -0 lines 0 comments Download
M discovery-cmdline-sample/instructions.html View 1 2 3 1 chunk +8 lines, -1 line 0 comments Download
M discovery-cmdline-sample/pom.xml View 1 1 chunk +1 line, -1 line 0 comments Download
M discovery-cmdline-sample/src/main/java/com/google/api/services/samples/discovery/cmdline/DiscoverySample.java View 8 chunks +16 lines, -30 lines 0 comments Download
M docs-cmdline-sample/.project View 1 chunk +5 lines, -0 lines 0 comments Download
M docs-cmdline-sample/instructions.html View 1 2 3 1 chunk +5 lines, -3 lines 0 comments Download
M docs-cmdline-sample/pom.xml View 1 chunk +2 lines, -2 lines 0 comments Download
M docs-cmdline-sample/src/main/java/com/google/api/services/samples/docs/cmdline/DocsSample.java View 4 chunks +11 lines, -20 lines 0 comments Download
M latitude-cmdline-sample/.project View 1 chunk +5 lines, -0 lines 0 comments Download
M latitude-cmdline-sample/instructions.html View 1 2 3 1 chunk +5 lines, -3 lines 0 comments Download
M latitude-cmdline-sample/pom.xml View 1 chunk +1 line, -1 line 0 comments Download
M latitude-cmdline-sample/src/main/java/com/google/api/services/samples/latitude/cmdline/LatitudeSample.java View 3 chunks +6 lines, -14 lines 0 comments Download
M moderator-cmdline-sample/.project View 1 chunk +5 lines, -0 lines 0 comments Download
M moderator-cmdline-sample/instructions.html View 1 2 3 1 chunk +7 lines, -5 lines 0 comments Download
M moderator-cmdline-sample/pom.xml View 1 chunk +1 line, -1 line 0 comments Download
M moderator-cmdline-sample/src/main/java/com/google/api/services/samples/moderator/cmdline/ModeratorSample.java View 4 chunks +6 lines, -14 lines 0 comments Download
M picasa-android-sample/.classpath View 1 1 chunk +10 lines, -10 lines 0 comments Download
M picasa-android-sample/pom.xml View 1 1 chunk +5 lines, -5 lines 0 comments Download
M picasa-cmdline-sample/.project View 1 chunk +5 lines, -0 lines 0 comments Download
M picasa-cmdline-sample/instructions.html View 1 2 3 1 chunk +5 lines, -3 lines 0 comments Download
M picasa-cmdline-sample/pom.xml View 1 chunk +2 lines, -2 lines 0 comments Download
M picasa-cmdline-sample/src/main/java/com/google/api/services/samples/picasa/cmdline/PicasaSample.java View 5 chunks +13 lines, -22 lines 0 comments Download
M prediction-cmdline-sample/instructions.html View 1 2 3 2 chunks +6 lines, -4 lines 0 comments Download
M prediction-cmdline-sample/pom.xml View 1 1 chunk +1 line, -1 line 0 comments Download
M prediction-cmdline-sample/src/main/java/com/google/api/services/samples/prediction/cmdline/PredictionSample.java View 4 chunks +8 lines, -22 lines 0 comments Download
M shared/gdata/shared-sample-calendar/pom.xml View 2 chunks +2 lines, -2 lines 0 comments Download
M shared/gdata/shared-sample-docs/pom.xml View 2 chunks +2 lines, -2 lines 0 comments Download
M shared/gdata/shared-sample-gdata/pom.xml View 2 chunks +2 lines, -2 lines 0 comments Download
M shared/gdata/shared-sample-picasa/pom.xml View 2 chunks +2 lines, -2 lines 0 comments Download
M shared/shared-sample-android/pom.xml View 1 1 chunk +1 line, -1 line 0 comments Download
M shared/shared-sample-cmdline/.classpath View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M shared/shared-sample-cmdline/pom.xml View 2 chunks +2 lines, -2 lines 0 comments Download
A shared/shared-sample-cmdline/src/main/java/com/google/api/services/samples/shared/cmdline/CmdlineUtils.java View 1 chunk +44 lines, -0 lines 0 comments Download
M shared/shared-sample-cmdline/src/main/java/com/google/api/services/samples/shared/cmdline/oauth2/OAuth2ClientCredentials.java View 1 2 3 3 chunks +51 lines, -14 lines 0 comments Download
M shared/shared-sample-cmdline/src/main/java/com/google/api/services/samples/shared/cmdline/oauth2/OAuth2Native.java View 7 chunks +20 lines, -45 lines 0 comments Download
A shared/shared-sample-cmdline/src/main/resources/client_secrets.json View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M siteVerification-cmdline-sample/.project View 1 chunk +5 lines, -0 lines 0 comments Download
M siteVerification-cmdline-sample/instructions.html View 1 2 3 1 chunk +7 lines, -4 lines 0 comments Download
M siteVerification-cmdline-sample/pom.xml View 1 chunk +1 line, -1 line 0 comments Download
M siteVerification-cmdline-sample/src/main/java/com/google/api/services/samples/verification/cmdline/VerificationSample.java View 4 chunks +5 lines, -12 lines 0 comments Download
M taskqueue-cmdline-sample/.project View 1 chunk +5 lines, -0 lines 0 comments Download
M taskqueue-cmdline-sample/instructions.html View 1 2 3 1 chunk +5 lines, -3 lines 0 comments Download
M taskqueue-cmdline-sample/pom.xml View 1 chunk +1 line, -1 line 0 comments Download
M taskqueue-cmdline-sample/src/main/java/com/google/api/services/samples/taskqueue/cmdline/TaskQueueSample.java View 3 chunks +6 lines, -18 lines 0 comments Download
M tasks-android-sample/.classpath View 1 1 chunk +10 lines, -10 lines 0 comments Download
M tasks-android-sample/.project View 1 1 chunk +5 lines, -0 lines 0 comments Download
M tasks-android-sample/pom.xml View 1 1 chunk +2 lines, -2 lines 0 comments Download
M youtube-jsonc-sample/.project View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M youtube-jsonc-sample/pom.xml View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6
yanivi
13 years, 6 months ago (2011-11-07 16:21:48 UTC) #1
yanivi
13 years, 6 months ago (2011-11-07 16:36:50 UTC) #2
rmistry
LGTM http://codereview.appspot.com/5348047/diff/8001/shared/shared-sample-cmdline/src/main/java/com/google/api/services/samples/shared/cmdline/oauth2/OAuth2ClientCredentials.java File shared/shared-sample-cmdline/src/main/java/com/google/api/services/samples/shared/cmdline/oauth2/OAuth2ClientCredentials.java (right): http://codereview.appspot.com/5348047/diff/8001/shared/shared-sample-cmdline/src/main/java/com/google/api/services/samples/shared/cmdline/oauth2/OAuth2ClientCredentials.java#newcode77 shared/shared-sample-cmdline/src/main/java/com/google/api/services/samples/shared/cmdline/oauth2/OAuth2ClientCredentials.java:77: "Please enter your client ID and secret from ...
13 years, 6 months ago (2011-11-07 16:46:27 UTC) #3
yanivi
13 years, 6 months ago (2011-11-07 17:08:20 UTC) #4
yanivi
submitting now... http://codereview.appspot.com/5348047/diff/8001/shared/shared-sample-cmdline/src/main/java/com/google/api/services/samples/shared/cmdline/oauth2/OAuth2ClientCredentials.java File shared/shared-sample-cmdline/src/main/java/com/google/api/services/samples/shared/cmdline/oauth2/OAuth2ClientCredentials.java (right): http://codereview.appspot.com/5348047/diff/8001/shared/shared-sample-cmdline/src/main/java/com/google/api/services/samples/shared/cmdline/oauth2/OAuth2ClientCredentials.java#newcode77 shared/shared-sample-cmdline/src/main/java/com/google/api/services/samples/shared/cmdline/oauth2/OAuth2ClientCredentials.java:77: "Please enter your client ID and secret ...
13 years, 6 months ago (2011-11-07 17:10:22 UTC) #5
rmistry
13 years, 6 months ago (2011-11-07 17:11:09 UTC) #6
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b