Issue 5344046: fix android samples

Issue 5344046: fix android samples (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by yanivi

Modified:
13 years, 6 months ago

Reviewers:
rmistry

Base URL:
https://code.google.com/p/google-api-java-client.samples/

Visibility:
Public.

Patch Set 1 #

Total comments: 2

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+120 lines, -45 lines)			Patch
M	picasa-android-sample/.classpath	View	2 chunks	+22 lines, -9 lines	0 comments	Download
A	picasa-android-sample/proguard.cfg	View	1 chunk	+48 lines, -0 lines	0 comments	Download
M	picasa-android-sample/project.properties	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tasks-android-sample/.classpath	View	1 chunk	+25 lines, -22 lines	0 comments	Download
M	tasks-android-sample/pom.xml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tasks-android-sample/src/main/java/com/google/api/services/samples/tasks/android/TasksSample.java	View	7 chunks	+23 lines, -13 lines	2 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rmistry

LGTM http://codereview.appspot.com/5344046/diff/1/tasks-android-sample/src/main/java/com/google/api/services/samples/tasks/android/TasksSample.java File tasks-android-sample/src/main/java/com/google/api/services/samples/tasks/android/TasksSample.java (right): http://codereview.appspot.com/5344046/diff/1/tasks-android-sample/src/main/java/com/google/api/services/samples/tasks/android/TasksSample.java#newcode3 tasks-android-sample/src/main/java/com/google/api/services/samples/tasks/android/TasksSample.java:3: * whitespace here and in a few places ...

13 years, 6 months ago (2011-11-04 21:11:24 UTC) #2

yanivi

http://codereview.appspot.com/5344046/diff/1/tasks-android-sample/src/main/java/com/google/api/services/samples/tasks/android/TasksSample.java File tasks-android-sample/src/main/java/com/google/api/services/samples/tasks/android/TasksSample.java (right): http://codereview.appspot.com/5344046/diff/1/tasks-android-sample/src/main/java/com/google/api/services/samples/tasks/android/TasksSample.java#newcode3 tasks-android-sample/src/main/java/com/google/api/services/samples/tasks/android/TasksSample.java:3: * On 2011/11/04 21:11:24, rmistry wrote: > whitespace here ...

13 years, 6 months ago (2011-11-04 21:14:16 UTC) #3

rmistry

13 years, 6 months ago (2011-11-04 21:16:18 UTC) #4

On 2011/11/04 21:14:16, yanivi wrote:
>
http://codereview.appspot.com/5344046/diff/1/tasks-android-sample/src/main/ja...
> File
>
tasks-android-sample/src/main/java/com/google/api/services/samples/tasks/android/TasksSample.java
> (right):
> 
>
http://codereview.appspot.com/5344046/diff/1/tasks-android-sample/src/main/ja...
>
tasks-android-sample/src/main/java/com/google/api/services/samples/tasks/android/TasksSample.java:3:
> *
> On 2011/11/04 21:11:24, rmistry wrote:
> > whitespace here and in a few places below.
> 
> Not sure what this comment means.  You know I am just letting Eclipse
> auto-format my file.  Kind of annoying that it changes more lines than it
needs
> to, but it is awfully convenient.  Mind if I keep it as is?

Thats fine, I had the same problem and installed a plugin that stripped off the
whitespace.
Not a big deal at all.

Expand All Messages | Collapse All Messages