Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(528)

Issue 5343044: CLWPR module for ns-3.11

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 7 months ago by Konstantinos Katsaros
Modified:
4 years, 1 month ago
Reviewers:
tpecorella, Tommaso Pecorella, yacine.mahmoud7
CC:
ns-3-reviews_googlegroups.com
Base URL:
http://ns-3-clwpr.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This issue adds the CLWPR module to ns-3.11 CLWPR (Cross Layer, Weighted, Position-based, Routing) is a Ipv4 routing protocol for ad-hoc networks optimized for urban VANETs. Currently it is in early stages, not so much optimized, but it is highly configurable. A recent publication that I have on this protocol and will be presented in IEEE VNC 2011 can be downloaded from my website: http://info.ee.surrey.ac.uk/Personal/K.Katsaros/papers/KK_CLWPR_VNC_11.pdf In addition, the Winner-models module was extracted from iTETRIS platform and is included in this patch.

Patch Set 1 #

Patch Set 2 : This patch is a clear CLWPR module commit #

Total comments: 10

Patch Set 3 : SnrTag in wifi-module, added comments for clwpr-map #

Unified diffs Side-by-side diffs Delta from patch set Stats (+251 lines, -126 lines) Patch
A . View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M scratch/simple-clwpr-example.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/clwpr/model/clwpr-repositories.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/clwpr/model/clwpr-routing-protocol.h View 1 2 2 chunks +2 lines, -38 lines 0 comments Download
M src/mobility/helper/mobility-helper.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/mobility/helper/mobility-helper.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M src/mobility/model/clwpr-map.h View 1 2 2 chunks +171 lines, -27 lines 0 comments Download
M src/mobility/model/clwpr-map.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/mobility/model/constant-position-mobility-model.h View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M src/mobility/model/mobility-model.h View 1 2 3 chunks +0 lines, -11 lines 0 comments Download
M src/mobility/model/mobility-model.cc View 1 2 2 chunks +3 lines, -39 lines 0 comments Download
A src/wifi/model/snr-tag.h View 1 2 1 chunk +69 lines, -0 lines 0 comments Download
M src/wifi/model/yans-wifi-phy.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/wifi/test/wifi-phy-test.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M src/wifi/wscript View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4
Tommaso Pecorella
Hi, here are some comments. I didn't yet go in details into the core of ...
6 years, 7 months ago (2011-11-07 23:45:12 UTC) #1
Konstantinos Katsaros
Dear Tomasso, Thanks for the feedback. Regarding mobility files, those commented by Ramon Bauza are ...
6 years, 7 months ago (2011-11-09 00:05:55 UTC) #2
tpecorella_mac.com
Hi Kostantinos, good, I'll move on with the review. And yes, the best place for ...
6 years, 7 months ago (2011-11-09 20:19:24 UTC) #3
yacine.mahmoud7
4 years, 1 month ago (2014-04-28 11:28:05 UTC) #4
On 2011/11/09 20:19:24, tpecorella_mac.com wrote:
> Hi Kostantinos,
> 
> good, I'll move on with the review. And yes, the best place for the SnrTag is
> indeed in the WiFiPhy. I could be very useful for other modules as well (e.g.,
> modules to switch interfaces).
> 
> Cheers,
> 
> Tommaso
> 
> 
> 
> Tommaso Pecorella - Ph.D.
> 
> Assistant professor
> Dpt. Elettronica e Telecomunicazioni
> Università di Firenze
> 
> CNIT - Università di Firenze Unit
> 
> via di S. Marta 3
> 50139, Firenze
> ITALY
> 
> email: mailto:tommaso.pecorella@unifi.it
>        mailto:tommaso.pecorella@cnit.it
> 
> phone : +39-055-4796412
> mobile: +39-320-4379803
> fax   : +39-055-494569
> 
> On 09 Nov, 2011,at 01:05 AM, Kostantinos Katsaros
<mailto:dinos.katsaros@gmail.com>
> wrote:
> 
> Dear Tomasso,
> 
> Thanks for the feedback.
> 
> Regarding mobility files, those commented by Ramon Bauza are part of the
iTETRIS
> and just forgot to remove them.
> 
> I have properly commented clwpr-map.h if that's what you mean with
indentation.
> The use of this class is a basic navigation system.
> 
> Regarding the SnrTag, you are right, I shouldn't have included the
> clwpr-protocol.h in PHY, I only needed the SnrTag from that. I created a new
> header file in wifi module, only for SnrTag, since others might want to use
it.

Hello, 
Please i need help for download clwpr-module.h for runnig the script. Please
Hepl me !! thank you All for this work
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b