On 2011/11/08 15:36:05, techtonik wrote: > To get you familiar with code reviews, please review ...
14 years, 4 months ago
(2011-11-08 21:23:45 UTC)
#3
On 2011/11/08 15:36:05, techtonik wrote:
> To get you familiar with code reviews, please review this change to Project
> Explorer help.
Ok, so, let's that I approve this change (which I really do by the way).
What now? Can we push this to Spyder's repository automatically?
I see that there is a tab "Repositories" on the top of the page: do we have to
add Spyder's repository there?
On 2011/11/08 21:23:45, pierre.raybaut wrote: > On 2011/11/08 15:36:05, techtonik wrote: > > To get ...
14 years, 4 months ago
(2011-11-10 17:51:14 UTC)
#4
On 2011/11/08 21:23:45, pierre.raybaut wrote:
> On 2011/11/08 15:36:05, techtonik wrote:
> > To get you familiar with code reviews, please review this change to Project
> > Explorer help.
>
> Ok, so, let's that I approve this change (which I really do by the way).
You can label it LGTM and it will be visible that the change is approved.
> What now? Can we push this to Spyder's repository automatically?
Not without some tools, but it's certainly possible to apply changeset using `hg
patch` on the `Download raw patch set` URL.
> I see that there is a tab "Repositories" on the top of the page: do we have to
> add Spyder's repository there?
No. It is an old interface to query reviews for specific repository. Now you may
use 'More Reviews' link on the right to see all issues for repository of the
current issue. The id of repository is detected by review upload script
automatically.
Issue 5338049: Simplify workspace/project description
(Closed)
Created 14 years, 4 months ago by techtonik
Modified 14 years, 4 months ago
Reviewers: pierre.raybaut, Carlos Córdoba
Base URL:
Comments: 0